-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update commands with resource builders to use external versions #20514
Update commands with resource builders to use external versions #20514
Conversation
hack/import-restrictions.json
Outdated
@@ -477,7 +477,9 @@ | |||
"github.com/openshift/origin/pkg/authorization/generated", | |||
"github.com/openshift/origin/pkg/build/apis/build/v1", | |||
"github.com/openshift/origin/pkg/build/generated", | |||
"github.com/openshift/origin/pkg/image/apis/image/v1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like the indentation is off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phew 😉
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: juanvallejo, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This supersedes #20400.
/assign @juanvallejo
I've picked one more upstream PR which was fixing logs interface and fixed the small things that were failing. Let's see how the tests are on it.