Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 64971: fix field removal in mutating admission webhooks #20524

Closed
wants to merge 1 commit into from
Closed

UPSTREAM: 64971: fix field removal in mutating admission webhooks #20524

wants to merge 1 commit into from

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Aug 2, 2018 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2018
@smarterclayton
Copy link
Contributor

/retest

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton smarterclayton removed the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2018
@smarterclayton
Copy link
Contributor

Wierd, #20509 already merged, why is this not listed as a conflict?

@sttts
Copy link
Contributor Author

sttts commented Aug 3, 2018

/retest

@sttts
Copy link
Contributor Author

sttts commented Aug 3, 2018

Wierd, #20509 already merged, why is this not listed as a conflict?

Probably because my and @pmorie's patch result byte-wise equal files. Github does not complain.

@sttts sttts closed this Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@enj enj Awaiting requested review from enj

Assignees

@smarterclayton smarterclayton

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sttts @smarterclayton @openshift-ci-robot @deads2k