Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: ensure perFSGroup quantity is positive #20564

Merged

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Aug 7, 2018

@sjenning sjenning added kind/bug Categorizes issue or PR as related to a bug. sig/pod labels Aug 7, 2018
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2018
@sjenning sjenning changed the title UPSTREAM: <carry>: ensure perFSGroup quanity is positive UPSTREAM: <carry>: ensure perFSGroup quantity is positive Aug 7, 2018
@@ -83,6 +83,10 @@ func PatchVolumePluginsForLocalQuota(rootdir string, plugins *[]volume.VolumePlu
return fmt.Errorf("unable to parse \"%s\" as a quantity", volumeConfig.LocalQuota.PerFSGroup)
}

if quota.Value() <= 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is perFSGroup able to be set to 0? Then this comparison would be < 0. Just double checking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically that would make all of the emptydirs effectively read-only and.. well.. permanently empty. So that didn't seem like something someone would ever want in my mind. Granted, you could set it to 1 bytes and probably be in the same boat but if you set a non-zero lower limit, you'd have to document it and I didn't want to do that 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@rphillips
Copy link
Contributor

/lgtm
/assign @derekwaynecarr

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2018
@derekwaynecarr
Copy link
Member

/lgtm
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, rphillips, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2018
@openshift-merge-robot openshift-merge-robot merged commit 770b621 into openshift:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. sig/pod size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants