Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate oc types #21000

Merged
merged 2 commits into from
Sep 17, 2018

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Sep 17, 2018

/assign @mfojtik

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2018
Short: "An introduction to concepts and types",
Long: fmt.Sprintf(typesLong, buf.String()),
Example: fmt.Sprintf(typesExample, fullName),
Deprecated: "use official docs instead",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"please refer to official documentation instead"

@mfojtik
Copy link
Contributor

mfojtik commented Sep 17, 2018

/lgtm

Need release note update.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@soltysh
Copy link
Contributor Author

soltysh commented Sep 17, 2018

Need release note update.

Already there.

@soltysh
Copy link
Contributor Author

soltysh commented Sep 17, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit a8ab70e into openshift:release-3.11 Sep 17, 2018
@soltysh soltysh deleted the deprecate_types branch September 18, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants