Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.9] Bug 1749930: ImageGC fixes #23761

Merged
merged 2 commits into from
Oct 9, 2019
Merged

[3.9] Bug 1749930: ImageGC fixes #23761

merged 2 commits into from
Oct 9, 2019

Conversation

jottofar
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2019
@jottofar
Copy link
Contributor Author

/assign @sjenning

@rphillips
Copy link
Contributor

/retitle [3.9] Bug 1749930: ImageGC fixes

@openshift-ci-robot openshift-ci-robot changed the title [3.9] ImageGC fixes: Bug 1749930 [3.9] Bug 1749930: ImageGC fixes Sep 10, 2019
@openshift-ci-robot
Copy link

@jottofar: This pull request references Bugzilla bug 1749930, which is invalid:

  • expected dependent Bugzilla bug 1647348 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[3.9] Bug 1749930: ImageGC fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 10, 2019
@jottofar
Copy link
Contributor Author

/retest

1 similar comment
@jottofar
Copy link
Contributor Author

/retest

@jottofar
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 13, 2019
@openshift-ci-robot
Copy link

@jottofar: This pull request references Bugzilla bug 1749930, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 13, 2019
@jottofar
Copy link
Contributor Author

/retest

4 similar comments
@jottofar
Copy link
Contributor Author

/retest

@jottofar
Copy link
Contributor Author

/retest

@jottofar
Copy link
Contributor Author

/retest

@jmrodri
Copy link
Contributor

jmrodri commented Sep 26, 2019

/retest

@jottofar
Copy link
Contributor Author

/retest

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@sjenning
Copy link
Contributor

this PR is missing a follow on commit that fixed a panic that this change introduces. See the 3.10 PR.

#23183

The 3.10 PR would need to merge before this one.
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2019
@jottofar
Copy link
Contributor Author

jottofar commented Oct 1, 2019

@sjenning I did pickup that panic fix but included everything in one commit:

origin/vendor/k8s.io/kubernetes/pkg/kubelet/dockershim/docker_image.go

Line 106 in 8d3126c

if imageInspect == nil {

@jottofar
Copy link
Contributor Author

jottofar commented Oct 1, 2019

@sjenning also, isn't the 3.10 PR just waiting for approval?

@jottofar
Copy link
Contributor Author

jottofar commented Oct 3, 2019

@sjenning still need action on this please

@rphillips
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link

@rphillips: This pull request references Bugzilla bug 1749930, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@rphillips
Copy link
Contributor

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 8, 2019
@rphillips
Copy link
Contributor

/cc @derekwaynecarr

@rphillips
Copy link
Contributor

/test cmd

@derekwaynecarr
Copy link
Member

this doesn't appear to compile... how was this verified?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@rphillips
Copy link
Contributor

build passes

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@jottofar
Copy link
Contributor Author

jottofar commented Oct 8, 2019

/cc @derekwaynecarr

@derekwaynecarr
Copy link
Member

/lgtm
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, jottofar, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit 8e36a3c into openshift:release-3.9 Oct 9, 2019
@openshift-ci-robot
Copy link

@jottofar: All pull requests linked via external trackers have merged. Bugzilla bug 1749930 has been moved to the MODIFIED state.

In response to this:

[3.9] Bug 1749930: ImageGC fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@rphillips rphillips

@sjenning sjenning

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jottofar @rphillips @openshift-ci-robot @jmrodri @sjenning @derekwaynecarr @openshift-merge-robot