-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1803163: UPSTREAM: 65357: Allow more fields at root of CRD schema if status is enabled #24540
Bug 1803163: UPSTREAM: 65357: Allow more fields at root of CRD schema if status is enabled #24540
Conversation
… enabled Signed-off-by: James Munnelly <[email protected]>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, munnerz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@munnerz: This pull request references Bugzilla bug 1803163, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@munnerz: This pull request references Bugzilla bug 1803163, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I created a Bugzilla bug against 3.11, and then created another against 4.4 (?) and set it as a dependent of the first Bugzilla bug as per @sttts's help. I cannot set the |
/bugzilla refresh |
@sttts: This pull request references Bugzilla bug 1803163, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@munnerz: All pull requests linked via external trackers have merged. Bugzilla bug 1803163 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR is a cherrypick from the upstream PR: kubernetes/kubernetes#65357
We're specifically requesting this change be cherrypicked back to release-3.11 as it currently prevents a single set of CRD resources being compatible with OpenShift 3.11 whilst also being considered 'structural' in OpenShift 4.x (and newer Kubernetes versions).
Without this patch, users will see errors like:
when installing CRDs that enable the
status
resource that (correctly) specifytype: object
at the root of their CRD schema.See also: cert-manager/cert-manager#2200
This patch applied clean from the upstream PR. This is my first contribution to
origin
so please let me know if I need to make any changes to how I've submitted this 😄/assign @sttts