Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: Validate port protocol case strictly #3258

Merged
merged 1 commit into from
Jun 22, 2015
Merged

UPSTREAM: Validate port protocol case strictly #3258

merged 1 commit into from
Jun 22, 2015

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Jun 17, 2015

Fixes #3257

@liggitt
Copy link
Contributor Author

liggitt commented Jun 17, 2015

Upstream PR: kubernetes/kubernetes#9919

@smarterclayton
Copy link
Contributor

Too risky to take

@smarterclayton smarterclayton added this to the 1.1.0 milestone Jun 17, 2015
@liggitt
Copy link
Contributor Author

liggitt commented Jun 17, 2015

@smarterclayton disagree... allowing in values that won't work is bad... things that make use of the protocols expect exact matches

@smarterclayton
Copy link
Contributor

Until upstream merges it we're stuck - not going to reject things that upstream accepts.

On Jun 17, 2015, at 8:56 AM, Jordan Liggitt [email protected] wrote:

@smarterclayton disagree... allowing in values that won't work is bad... things that make use of the protocols expect exact matches

—
Reply to this email directly or view it on GitHub.

@liggitt
Copy link
Contributor Author

liggitt commented Jun 20, 2015

merged upstream

@liggitt
Copy link
Contributor Author

liggitt commented Jun 20, 2015

[test]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/3263/)

@smarterclayton
Copy link
Contributor

LGTM [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/2508/) (Image: devenv-fedora_1844)

@liggitt
Copy link
Contributor Author

liggitt commented Jun 22, 2015 

[INFO] Verifying the docker-registry is up at 172.30.229.192
ERROR: gave up waiting for http://172.30.229.192:5000/healthz

@liggitt
Copy link
Contributor Author

liggitt commented Jun 22, 2015

re[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 0bf83e2

openshift-bot pushed a commit that referenced this pull request Jun 22, 2015
Merge pull request #3258 from liggitt/service_port_validation
076ab27 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 076ab27 into openshift:master Jun 22, 2015
@liggitt liggitt deleted the service_port_validation branch June 23, 2015 00:54
@sdodson sdodson mentioned this pull request Jun 30, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@liggitt @smarterclayton @openshift-bot