rsync: output warnings to stdout instead of using glog #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fabianofranz ptal |
|
or @bparees ptal |
|
lgtm [merge] |
|
[Test]ing while waiting on the merge queue |
|
LGTM |
|
@smarterclayton or @liggitt ptal |
| @@ -26,7 +26,7 @@ func (ss copyStrategies) Copy(source, destination *pathSpec, out, errOut io.Writ | |||
| err = s.Copy(source, destination, out, errBuf) | |||
| if _, isSetupError := err.(strategySetupError); isSetupError { | |||
| glog.V(4).Infof("Error output:\n%s", errBuf.String()) | |||
| glog.Warningf("Cannot use %s: %v", s.String(), err.Error()) | |||
| fmt.Fprintf(out, "WARNING: cannot use %s: %v", s.String(), err.Error()) | |||
There was a problem hiding this comment.
Should be to stderr - is that the case?
|
@smarterclayton thx, comments addressed |
|
LGTM [merge] |
smarterclayton
added
the
approved
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6677/) (Image: devenv-rhel7_2631) |
|
Evaluated for origin merge up to 2355304 |
|
Evaluated for origin test up to 2355304 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6677/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the use of glog for warning output