UPSTREAM: 16668: Fix hpa escalation

[deads2k]

pick for kubernetes/kubernetes#16661

@liggitt @smarterclayton we need this (or something like it) to make the HPA controller safe in 3.1
@DirectXMan12 @ncdc This is needed in or before #5310

[smarterclayton]

[test]

[smarterclayton]

I would recommend just carrying the changes that ignore the namespace on the field, rather than changing the kube object. If someone specifies the namespace, we merely ignore it. That reduces the risk of an upstream change.

[smarterclayton]

You have permission to carry the change that ignores Namespace without argument without upstream.

[deads2k]

I would recommend just carrying the changes that ignore the namespace on the field, rather than changing the kube object. If someone specifies the namespace, we merely ignore it. That reduces the risk of an upstream change.

I can do that, but the risk during rebase is high because the old field will still be referenceable.

[deads2k]

setup problem re[test]

[liggitt]

I don't want to leave a dangerous latent field in play for another controller to start using

[liggitt]

upstream has LGTM

[liggitt]

https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6593/

!!! Error in hack/../test/end-to-end/core.sh:156
    '[ "$(oc rsh ${BUILD_ID}-build 2>&1 | grep 'forbidden')" ]' exited with status 1
Call stack:
    1: hack/../test/end-to-end/core.sh:156 main(...)

[test]

[liggitt]

[test]

[liggitt]

#4351

error: deploymentConfig "test-deployment-config" cannot be updated: the object has been modified; please apply your changes to the latest version and try again
!!! Error in test/cmd/volumes.sh:17
    '[ "$(oc volume dc/test-deployment-config --add --name=vol2 --type=emptydir -m /opt)" ]' exited with status 1

[test]

[deads2k]

[merge]

[openshift-bot]

Evaluated for origin merge up to db848a0

[smarterclayton]

[test]

[smarterclayton]

[test]

[openshift-bot]

Evaluated for origin test up to db848a0

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6834/) (Image: devenv-rhel7_2638)

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6834/)