UPSTREAM: 16590: Create all streams before copying in exec/attach #5585
Conversation
|
[test] |
|
LGTM |
smarterclayton
added
the
approved
|
sorry... I'm taking back my LGTM... seeing a timeout in at least one windows box |
|
@ncdc I'm seeing timeouts in windows with this code... not sure what is different since I tried your patch, seems like the same change to me. I've tried in Windows Server 2012 R2 (from AWS), and Windows 7 Pro (vagrant on virtualbox) |
|
I've identified the issue. I'm working on a fix. This may affect upstream too. |
Create error, stdin, stdout, stderr streams first, and only start copying once all the streams have been created. This fixes an issue where the client immediately starts sending data for stdin before all the other streams have been created. This ends up blocking the spdy connection frame handler and causes the entire exec/attach session to time out.
ncdc
force-pushed
the
cherry-pick-16590
branch
from
50f9a4f
to
10a9b21
Compare
|
Fix applied to upstream and here |
|
What was the change? |
|
|
What Jordan said. I missed copying a condition from the old code to the new code correctly. I left out the tty part, so the client was always sending stderr even with tty=true. |
|
LGTM, @csrwng can you test? |
|
Latest test in Windows 2012R2 connecting to an Origin server with current master version is good. Ship it! |
|
[test] On Mon, Nov 2, 2015 at 3:33 PM, OpenShift Bot [email protected]
|
|
job 6617 failure was the github.com connectivity issue [test] |
|
[test] On Mon, Nov 2, 2015 at 5:57 PM, OpenShift Bot [email protected]
|
|
rsh forbidden flake (which is fixed), re[test] |
|
[test] |
|
Github timeout [test] On Tuesday, November 3, 2015, OpenShift Bot [email protected]
|
|
[test] On Tuesday, November 3, 2015, OpenShift Bot [email protected]
|
|
Evaluated for origin test up to 10a9b21 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6711/) |
|
Yes, green Jenkins!!! |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6711/) (Image: devenv-rhel7_2637) |
|
Evaluated for origin merge up to 10a9b21 |
Create error, stdin, stdout, stderr streams first, and only start
copying once all the streams have been created. This fixes an issue
where the client immediately starts sending data for stdin before all
the other streams have been created. This ends up blocking the spdy
connection frame handler and causes the entire exec/attach session to
time out.
Fixes #5377