Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 16818: Namespace controller should always get latest state … #5720

Merged
merged 1 commit into from
Nov 6, 2015
Merged

UPSTREAM: 16818: Namespace controller should always get latest state … #5720

merged 1 commit into from
Nov 6, 2015

Conversation

derekwaynecarr
Copy link
Member

…prior to deletion

This fixes slow-down when doing bulk namespace deletions.

/cc @smarterclayton @ncdc @eparis

@derekwaynecarr
Copy link
Member Author

https://bugzilla.redhat.com/show_bug.cgi?id=1277912

@smarterclayton
Copy link
Contributor

The e2e tests wedge as soon as we try the "namespace" test https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6906/consoleFull

@smarterclayton
Copy link
Contributor

Changes LGTM

@smarterclayton smarterclayton added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2015
@smarterclayton
Copy link
Contributor

Actually, we need this anyway...

@smarterclayton smarterclayton mentioned this pull request Nov 5, 2015
Merged
@smarterclayton
Copy link
Contributor

Your unit tests didn't compile.

On Wed, Nov 4, 2015 at 10:32 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/3949/
)

—
Reply to this email directly or view it on GitHub
#5720 (comment).

@liggitt liggitt added this to the 1.1.0 milestone Nov 5, 2015
@derekwaynecarr
Copy link
Member Author

Fixed

@derekwaynecarr
Copy link
Member Author

[test]

@liggitt
Copy link
Contributor

liggitt commented Nov 5, 2015

@smarterclayton removed merge tag, wasn't sure how you wanted to batch this

@liggitt
Copy link
Contributor

liggitt commented Nov 5, 2015

adding [merge] per @smarterclayton

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 2dad8c4

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 2dad8c4

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6931/) (Image: devenv-rhel7_2644)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/6931/)

openshift-bot pushed a commit that referenced this pull request Nov 6, 2015
Merge pull request #5720 from derekwaynecarr/16818
9bd5fb9 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 9bd5fb9 into openshift:master Nov 6, 2015
@soltysh soltysh mentioned this pull request Nov 6, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@derekwaynecarr derekwaynecarr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/reliability priority/P1
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@derekwaynecarr @smarterclayton @liggitt @openshift-bot