allow pvc by default #8298
allow pvc by default #8298
Conversation
|
@pweil- storage team really needs to own that - can you sync with @bchilds On Wed, Mar 30, 2016 at 11:38 AM, Paul Weil [email protected]
|
|
unit test to ensure all sccs include the fstypes we've determined should always be allowed by default, then LGTM |
|
test added to check bootstrapped constraints for |
| @@ -35,6 +38,12 @@ func TestBootstrappedConstraints(t *testing.T) { | |||
| if !reflect.DeepEqual(u, constraint.Users) { | |||
| t.Errorf("unexpected user access for %s. Found %v, wanted %v", constraint.Name, constraint.Users, u) | |||
| } | |||
|
|
|||
| for _, expectedVolume := range expectedVolumes { | |||
There was a problem hiding this comment.
nm, missed the check below
|
LGTM |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2601/) (Image: devenv-rhel7_3871) |
|
Evaluated for origin merge up to 020adab |
|
[Test]ing while waiting on the merge queue |
|
[test] On Wed, Mar 30, 2016 at 1:30 PM, OpenShift Bot [email protected]
|
|
Evaluated for origin test up to 020adab |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2601/) |
Fixes: #8297
@liggitt @smarterclayton - will work on an e2e test that uses pvcs