Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve display of logs in web console #8344

Merged
merged 1 commit into from
Apr 5, 2016
Merged

Improve display of logs in web console #8344

merged 1 commit into from
Apr 5, 2016

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Apr 4, 2016

Fill screen height and move ellipsis to bottom. Improve display of details and actions above log.

screen shot 2016-04-04 at 10 22 05 am

screen shot 2016-04-04 at 10 22 23 am

@smarterclayton @jwforres

@spadgett
Copy link
Member Author

spadgett commented Apr 4, 2016

[test]

@smarterclayton
Copy link
Contributor

Love it

On Mon, Apr 4, 2016 at 10:36 AM, Sam Padgett [email protected]
wrote:

[test]

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8344 (comment)

@smarterclayton
Copy link
Contributor

Approved for 3.2 if you think it is low risk enough.

On Mon, Apr 4, 2016 at 10:59 AM, Clayton Coleman [email protected]
wrote:

Love it

On Mon, Apr 4, 2016 at 10:36 AM, Sam Padgett [email protected]
wrote:

[test]

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8344 (comment)

@spadgett spadgett force-pushed the log-message-1.2 branch 5 times, most recently from fcd5a21 to a06b949 Compare April 4, 2016 17:36
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 4288c12

@jwforres
Copy link
Member

jwforres commented Apr 4, 2016

@spadgett LGTM if you are happy with the amount of testing you've done so far i think we can merge

@spadgett
Copy link
Member Author

spadgett commented Apr 4, 2016

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2682/)

@spadgett
Copy link
Member Author

spadgett commented Apr 4, 2016

[merge]

1 similar comment
@spadgett
Copy link
Member Author

spadgett commented Apr 4, 2016

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5513/) (Image: devenv-rhel7_3904)

@spadgett
Copy link
Member Author

spadgett commented Apr 5, 2016

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 4288c12

@openshift-bot openshift-bot merged commit ef1caba into openshift:master Apr 5, 2016
@spadgett spadgett deleted the log-message-1.2 branch April 5, 2016 10:36
@spadgett spadgett mentioned this pull request Apr 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spadgett @smarterclayton @openshift-bot @jwforres