Wrap oauth/login requests to clear in-memory session #8435
Conversation
liggitt
changed the title
|
@smarterclayton |
|
in addition to automated tests, I manually tested the following scenarios:
|
|
one pass, one flake (#8436), one known failure on conformance |
|
two clean runs, two known failures on conformance |
| } | ||
|
|
||
| return ret, nil | ||
| } | ||
|
|
||
| func BuildSessionAuth(secure bool, config *configapi.SessionConfig) (*session.Authenticator, error) { | ||
| func BuildSessionAuth(secure bool, config *configapi.SessionConfig) (*session.Authenticator, handlerWrapper, error) { |
There was a problem hiding this comment.
Returning private type feels slightly wierd on public function. Fine here though for now.
There was a problem hiding this comment.
wasn't used elsewhere, made the function private
|
Approved, Lgtm within the risk profile we are willing to accept. Merge when ready. |
|
[merge] |
|
Evaluated for origin test up to 852ca25 |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2873/) |
|
merge flaked on #8436 |
|
[merge] |
|
flake #8444 |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5559/) (Image: devenv-rhel7_3948) |
|
merge failed on #8403 which should be fixed in master now, re[merge] |
|
Evaluated for origin merge up to 852ca25 |
Adds wrappers around OAuth-specific endpoints to ensure we release session store memory when requests are complete