Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry import from the DockerHub on 401 #8574

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Retry import from the DockerHub on 401 #8574

merged 1 commit into from
Apr 22, 2016

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Apr 20, 2016 •
edited
Loading

Follow on to #8558

Fixes #7429 #8399 #8444

@smarterclayton smarterclayton mentioned this pull request Apr 20, 2016
Merged
@smarterclayton
Copy link
Contributor Author

[test]

@soltysh
Copy link
Contributor

soltysh commented Apr 20, 2016

LGTM, merge as soon as tests are green.

@smarterclayton
Copy link
Contributor Author

We're going to hold off on this for 1.2 just because of risk.

@smarterclayton
Copy link
Contributor Author

[test]

@smarterclayton
Copy link
Contributor Author

Flaked on #8491 [test]

On Wed, Apr 20, 2016 at 1:40 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3149/)

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#8574 (comment)

@smarterclayton
Copy link
Contributor Author

[test]

@smarterclayton
Copy link
Contributor Author

Adding a workaround for the legacy client (it's less work than ripping out
the code).

On Wed, Apr 20, 2016 at 2:46 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3154/)

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#8574 (comment)

@smarterclayton
Copy link
Contributor Author

role assignment flake

On Wed, Apr 20, 2016 at 7:00 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3160/)

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#8574 (comment)

@smarterclayton
Copy link
Contributor Author

[test]

@smarterclayton
Retry 401 unauthorized responses from registries within a window
8faa82f 
DockerHub generates JWT tokens that are valid from "now", which means
fast actions can get a 401 unauthorized if the second boundary on the
hub servers is not aligned. We retry 401 unauthorized requests
immediately (one time), then wait a small window of time before
retrying. If our operation is too slow (longer than the window) we do
not retry.

Probably an issue with Docker Trusted Registries as well.
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 8faa82f

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3163/)

@soltysh
Copy link
Contributor

soltysh commented Apr 21, 2016

Additional changes LGTM.

@soltysh soltysh added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2016
@smarterclayton
Copy link
Contributor Author

Given that flakes are blocking final merges, I'm merging this (we've had a lot of soak time). [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5661/) (Image: devenv-rhel7_4014)

@smarterclayton
Copy link
Contributor Author

Flake #8606 [merge]

On Fri, Apr 22, 2016 at 12:40 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/merge FAILURE (
https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5660/
)

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#8574 (comment)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 8faa82f

@openshift-bot openshift-bot merged commit 4c7a595 into openshift:master Apr 22, 2016
@csrwng csrwng mentioned this pull request Jul 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soltysh soltysh

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smarterclayton @soltysh @openshift-bot