Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: kola-denylist: add fips.* and ext.config.shared.networking.* on c9s #1544

Closed
wants to merge 2 commits into from

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jul 10, 2024

We're currently hitting OpenSSL issues there:
#1540


kola-denylist: add ext.config.shared.networking.* on c9s

A bunch of tests are failing because systemd-network-generator.service
is hitting SELinux denials:

https://issues.redhat.com/browse/RHEL-47033

Some of these tests are testing things that don't strictly need that
service, but test kargs that trigger it anyway. Other tests do (e.g.
ifname=) and so that functionality is indeed currently broken on c9s.

That said, there's continuing requests to have preliminary c9s
bootimages for testing. So let's not block on this issue for now.

@jlebon
Copy link
Member Author

jlebon commented Jul 10, 2024

/test scos-9-build-test-qemu
/test scos-9-build-test-metal

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jlebon
Copy link
Member Author

jlebon commented Jul 10, 2024

/test scos-9-build-test-qemu
/test scos-9-build-test-metal

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@jlebon jlebon changed the title c9s: unpin selinux-policy and denylist fips.enable kola-denylist: add fips.* on c9s Jul 10, 2024
@jlebon jlebon marked this pull request as ready for review July 10, 2024 15:58
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
@jlebon
Copy link
Member Author

jlebon commented Jul 10, 2024

CI failing on systemd-network-generator, tracked as part of #1514 (specifically https://issues.redhat.com/browse/RHEL-47033).

/override ci/prow/scos-9-build-test-qemu

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/scos-9-build-test-qemu

In response to this:

CI failing on systemd-network-generator, tracked as part of #1514 (specifically https://issues.redhat.com/browse/RHEL-47033).

/override ci/prow/scos-9-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jlebon jlebon changed the title kola-denylist: add fips.* on c9s NO-JIRA: kola-denylist: add fips.* on c9s Jul 13, 2024
@openshift-ci-robot
Copy link

@jlebon: This pull request explicitly references no jira issue.

In response to this:

We're currently hitting OpenSSL issues there:
#1540

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 13, 2024
@jlebon jlebon added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jul 13, 2024
We're currently hitting OpenSSL issues there:
openshift#1540
A bunch of tests are failing because `systemd-network-generator.service`
is hitting SELinux denials:

https://issues.redhat.com/browse/RHEL-47033

Some of these tests are testing things that don't strictly need that
service, but test kargs that trigger it anyway. Other tests do (e.g.
`ifname=`) and so that functionality is indeed currently broken on c9s.

That said, there's continuing requests to have preliminary c9s
bootimages for testing. So let's not block on this issue for now.
@jlebon jlebon changed the title NO-JIRA: kola-denylist: add fips.* on c9s NO-JIRA: kola-denylist: add fips.* and ext.config.shared.networking.* on c9s Aug 6, 2024
@jlebon
Copy link
Member Author

jlebon commented Aug 6, 2024

I've rebased this and now also added ext.config.shared.networking.* to the denylist for c9s. Let's see if that's enough to get some bootimages built.

Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

@jlebon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/rhcos-9-build-test-metal bea16e7 link true /test rhcos-9-build-test-metal
ci/prow/scos-9-build-test-qemu bea16e7 link true /test scos-9-build-test-qemu
ci/prow/rhcos-9-build-test-qemu bea16e7 link true /test rhcos-9-build-test-qemu
ci/prow/scos-9-build-test-metal bea16e7 link true /test scos-9-build-test-metal

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jlebon
Copy link
Member Author

jlebon commented Aug 7, 2024

We don't need the second commit here with the SELinux workaround in #1556. I've inlined the first commit here in that PR, so we can close this.

@jlebon jlebon closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants