Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [DNM] Mohit test udn scale1 #2280

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

trozet
Copy link
Contributor

@trozet trozet commented Aug 29, 2024

test udn scale fixes

Everytime a UDN was created, we were adding the all remote nodes for
every network all over again, including the default network. This makes
the checks on the annotations network aware.

Signed-off-by: Tim Rozet <[email protected]>
(cherry picked from commit 7310251)
Leverages the NAD Controller to also track primary networks. This should
be faster than listing all NADs in a namespace and iterating through
them to find the primary network for a namespace.

Signed-off-by: Tim Rozet <[email protected]>
(cherry picked from commit ae4205175d8c1b3ee3529b887b8afe10ec7f50da)
Modifies NAD Controller so it can be ran without invoking a network
manager and in this mode simply tracks what network is primary (active)
network for each namespace. This is only supported for now in priveleged
mode.

Signed-off-by: Tim Rozet <[email protected]>
(cherry picked from commit 4765fadea98d80873f966978e4230d8c0589b1b5)
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2024
@openshift-ci openshift-ci bot requested review from abhat and jcaamano August 29, 2024 20:27
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2024
@trozet
Copy link
Contributor Author

trozet commented Aug 30, 2024

/test images

Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

@trozet: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn 27c1053 link false /test e2e-azure-ovn
ci/prow/security 27c1053 link false /test security
ci/prow/e2e-metal-ipi-ovn-techpreview 27c1053 link false /test e2e-metal-ipi-ovn-techpreview
ci/prow/e2e-metal-ipi-ovn-ipv6-techpreview 27c1053 link false /test e2e-metal-ipi-ovn-ipv6-techpreview
ci/prow/e2e-azure-ovn-upgrade 27c1053 link true /test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn 27c1053 link true /test e2e-aws-ovn
ci/prow/e2e-aws-ovn-serial 27c1053 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-kubevirt 27c1053 link false /test e2e-aws-ovn-kubevirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants