Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-42940: Fix egress gateway pod cleanup for remote zone pods. #2316

Open
wants to merge 2 commits into
base: release-4.17
Choose a base branch
from
Open

OCPBUGS-42940: Fix egress gateway pod cleanup for remote zone pods. #2316

wants to merge 2 commits into from

Conversation

npinaeva
Copy link
Member

@npinaeva npinaeva commented Oct 9, 2024

@npinaeva
Add egress gateway e2e test option to delete gateway pod instead of
645deca 
re-labeling gateway pod. It uses different handlers for update and
delete pod internally.
Remove external.gateway from the dual-stack exclusion, as it is
supported for ipv6.

Signed-off-by: Nadia Pinaeva <[email protected]>
(cherry picked from commit 4b9c42b)
@npinaeva
Cleanup gateway pod for remote zone.
ad665cc 
For local zone pods, deleteLogicalPort cleans this up, but before IC
this function was called for all non-host-network pods, hence this
logic. After IC, deleteLogicalPort won't be called for all remote zone
pods, so condition is not needed.

Signed-off-by: Nadia Pinaeva <[email protected]>
(cherry picked from commit 839842b)
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 9, 2024
@openshift-ci-robot
Copy link
Contributor

@npinaeva: This pull request references Jira Issue OCPBUGS-42940, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-38753 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport of ovn-kubernetes/ovn-kubernetes#4744
d/s merge #2314

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@npinaeva
Copy link
Member Author

npinaeva commented Oct 9, 2024

/jira backport release-4.16,release-4.15,release-4.14

@openshift-ci-robot
Copy link
Contributor

@npinaeva: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14

In response to this:

/jira backport release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to this:

@npinaeva: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14

In response to this:

/jira backport release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@npinaeva
Copy link
Member Author

/retest

trozet
trozet approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@trozet
Copy link
Contributor

trozet commented Nov 1, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 1, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npinaeva, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2024
@trozet
Copy link
Contributor

trozet commented Nov 1, 2024

/retest-required

1 similar comment
@npinaeva
Copy link
Member Author

npinaeva commented Nov 4, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

@npinaeva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway ad665cc link false /test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/security ad665cc link false /test security
ci/prow/e2e-azure-ovn-techpreview ad665cc link false /test e2e-azure-ovn-techpreview
ci/prow/e2e-aws-ovn-kubevirt ad665cc link false /test e2e-aws-ovn-kubevirt
ci/prow/e2e-metal-ipi-ovn-ipv6-techpreview ad665cc link false /test e2e-metal-ipi-ovn-ipv6-techpreview
ci/prow/e2e-openstack-ovn ad665cc link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-techpreview ad665cc link false /test e2e-metal-ipi-ovn-techpreview
ci/prow/e2e-azure-ovn-upgrade ad665cc link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@asood-rh
Copy link

asood-rh commented Nov 4, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet trozet approved these changes

@jcaamano jcaamano Awaiting requested review from jcaamano

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zhaozhanqi zhaozhanqi

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.