Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow: Drop some plugins from coreos/rpm-ostree #16706

Merged

Conversation

cgwalters
Copy link
Member

Most notably drop approve and lgtm, which are responsible
for a lot of comment spam. We are going to experiment
with using the Github-native methods for this.

xref coreos/fedora-coreos-tracker#764

@cgwalters
Copy link
Member Author

/hold
for approval from another coreos/rpm-ostree developer by tomorrow.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2021
Most notably drop approve and lgtm, which are responsible
for a lot of comment spam.  We are going to experiment
with using the Github-native methods for this.

xref coreos/fedora-coreos-tracker#764
@cgwalters
Copy link
Member Author

To be explicit, after this merges PRs to the rpm-ostree repo would use the Github Review Changes -> "Approve" flow for the equivalent of "/approve" and the "Merge after tests pass" button (which...hmm, I think we need a repo admin to enable).

@jlebon
Copy link
Member

jlebon commented Mar 11, 2021

Definitely interested to try this out!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2021
@cgwalters
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2021
Copy link
Contributor

@kelvinfan001 kelvinfan001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is worth experimenting with. I always thought the Github flow was more intuitive and user-firendly, and the reduction in spam feels a lot cleaner too :)

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2021
@cgwalters
Copy link
Member Author

/retest

Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try!

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, cgwalters, jlebon, kelvinfan001, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d5ad8ff into openshift:master Mar 11, 2021
@openshift-ci-robot
Copy link
Contributor

@cgwalters: Updated the following 4 configmaps:

  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
  • config configmap in namespace ci at cluster api.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key config.yaml using file core-services/prow/02_config/_config.yaml
  • plugins configmap in namespace ci at cluster api.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml

In response to this:

Most notably drop approve and lgtm, which are responsible
for a lot of comment spam. We are going to experiment
with using the Github-native methods for this.

xref coreos/fedora-coreos-tracker#764

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants