-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prow: Drop some plugins from coreos/rpm-ostree #16706
prow: Drop some plugins from coreos/rpm-ostree #16706
Conversation
/hold |
6f0c956
to
4f1e33e
Compare
Most notably drop approve and lgtm, which are responsible for a lot of comment spam. We are going to experiment with using the Github-native methods for this. xref coreos/fedora-coreos-tracker#764
4f1e33e
to
a4b747c
Compare
To be explicit, after this merges PRs to the rpm-ostree repo would use the Github Review Changes -> "Approve" flow for the equivalent of "/approve" and the "Merge after tests pass" button (which...hmm, I think we need a repo admin to enable). |
Definitely interested to try this out! |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is worth experimenting with. I always thought the Github flow was more intuitive and user-firendly, and the reduction in spam feels a lot cleaner too :)
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, cgwalters, jlebon, kelvinfan001, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cgwalters: Updated the following 4 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Most notably drop approve and lgtm, which are responsible
for a lot of comment spam. We are going to experiment
with using the Github-native methods for this.
xref coreos/fedora-coreos-tracker#764