Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ODH] Onboard rocm pytorch and tensorflow runtimes on the ci main config #54567

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

atheo89
Copy link
Contributor

@atheo89 atheo89 commented Jul 19, 2024

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@atheo89: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-notebooks-main-amd-runtimes-ubi9-e2e-tests opendatahub-io/notebooks presubmit Presubmit changed
pull-ci-opendatahub-io-notebooks-main-runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Presubmit changed
pull-ci-opendatahub-io-notebooks-main-anaconda-ubi8-e2e-tests opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-codeserver-notebook-e2e-tests opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-habana-notebooks-e2e-tests opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-images opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-intel-notebooks-e2e-tests opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-jupyter-datascience-anaconda-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-amd-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-amd-jupyter-minimal-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-base-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-codeserver-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-ds-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-minimal-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-jupyter-tf-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-rstudio-c9s-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-cuda-ubi9-python-3-9-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed
pull-ci-opendatahub-io-notebooks-main-notebook-habana-1-13-0-ubi8-python-3-8-pr-image-mirror opendatahub-io/notebooks presubmit Ci-operator config changed

A total of 51 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jiridanek
Copy link
Member

/pj-rehearse auto-ack

@openshift-ci-robot
Copy link
Contributor

@jiridanek: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jiridanek
Copy link
Member

jiridanek commented Jul 19, 2024

the failing rehearse is failing as expected, the PRs in opendatahub-io/notebooks must be merged first for rehearsals to succeed

@atheo89
Copy link
Contributor Author

atheo89 commented Jul 19, 2024

the failing rehearse is failing as expected, the PRs in opendatahub-io/notebooks must be merged first for rehearsals to succeed

It is the chicken-egg situation here

@jiridanek
Copy link
Member

jiridanek commented Jul 19, 2024

It is the chicken-egg situation here

do you propose to slaughter the chicken first or crack the egg first?

@atheo89
Copy link
Contributor Author

atheo89 commented Jul 19, 2024

It is the chicken-egg situation here
do you propose to slaughter the chicken first or crack the egg first?

I am against to violence; I will let nature work its miracle! 🤣

@atheo89
Copy link
Contributor Author

atheo89 commented Jul 19, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@atheo89: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 19, 2024
@jiridanek
Copy link
Member

/pj-rehearse ack

acking on red seems pretty violent to me ;P

@jiridanek
Copy link
Member

but yeah, let's go this way

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

@atheo89: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/opendatahub-io/notebooks/main/runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror 4df5bbf link unknown /pj-rehearse pull-ci-opendatahub-io-notebooks-main-runtime-rocm-pytorch-ubi9-python-3-9-pr-image-mirror
ci/rehearse/opendatahub-io/notebooks/main/habana-notebooks-e2e-tests 4df5bbf link unknown /pj-rehearse pull-ci-opendatahub-io-notebooks-main-habana-notebooks-e2e-tests
ci/rehearse/opendatahub-io/notebooks/main/anaconda-ubi8-e2e-tests 4df5bbf link unknown /pj-rehearse pull-ci-opendatahub-io-notebooks-main-anaconda-ubi8-e2e-tests
ci/rehearse/opendatahub-io/notebooks/main/amd-runtimes-ubi9-e2e-tests 4df5bbf link unknown /pj-rehearse pull-ci-opendatahub-io-notebooks-main-amd-runtimes-ubi9-e2e-tests
ci/rehearse/opendatahub-io/notebooks/main/codeserver-notebook-e2e-tests 4df5bbf link unknown /pj-rehearse pull-ci-opendatahub-io-notebooks-main-codeserver-notebook-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d457bf9 into openshift:master Jul 19, 2024
17 of 22 checks passed
aviavraham pushed a commit to aviavraham/openshift_release that referenced this pull request Jul 22, 2024
aviavraham pushed a commit to aviavraham/openshift_release that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants