Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ODH] Fix rocm runtimes naming on 2024a build branch #55441

Merged
merged 1 commit into from
Aug 12, 2024
Merged

[ODH] Fix rocm runtimes naming on 2024a build branch #55441

merged 1 commit into from
Aug 12, 2024

Conversation

atheo89
Copy link
Contributor

@atheo89 atheo89 commented Aug 12, 2024

Follow up to this: #54777

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 12, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@atheo89: no rehearsable tests are affected by this change

@atheo89 atheo89 mentioned this pull request Aug 12, 2024
Merged
3 tasks
@atheo89 atheo89 changed the title [ODH] Fix rocm runtimes naming [ODH] Fix rocm runtimes naming on 2024a build branch Aug 12, 2024
@jiridanek
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 12, 2024

@atheo89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jstourac
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jiridanek, jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2b497c5 into openshift:master Aug 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiridanek jiridanek Awaiting requested review from jiridanek

@jstourac jstourac Awaiting requested review from jstourac

Assignees

@jiridanek jiridanek

@jstourac jstourac

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atheo89 @openshift-ci-robot @jiridanek @jstourac