-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openshift-loki: Bump builder to go1.22 for 5.x releases #57756
openshift-loki: Bump builder to go1.22 for 5.x releases #57756
Conversation
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse more |
@periklis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
/pj-rehearse more |
@periklis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoaoBraveCoding, periklis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@periklis: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/pj-rehearse ack |
@periklis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
9e78cbd
into
openshift:master
Unblocks building:
Notes for the reviewer
The following rehearse jobs fail because building
controller-gen
on go1.22 requires>= v0.14.0
. This is addressed in the PRs above:pull-ci-openshift-loki-release-5.6-build
pull-ci-openshift-loki-release-5.6-lint
pull-ci-openshift-loki-release-5.8-build
pull-ci-openshift-loki-release-5.8-lint
Refs: LOG-6169
/cc @xperimental @JoaoBraveCoding