-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump golang version to 1.21 #380
Conversation
Hi @spotlesstofu. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @spotlesstofu !
/retest-required |
@spotlesstofu shouldn't this be targeted for devel branch ? |
Indeed I overlooked it was targetting a dummy branch... @spotlesstofu is the PR ok to go to |
@gkurz it is OK now. The bot tells it needs rebase, but it shouldn't. I changed the target branch and rebased already. |
/test |
@gkurz: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @spotlesstofu ! We don't formally ask for it but it is generally good practice to add some extra info in the commit message and a S-o-b tag. e.g.
|
Downstream OSC was already bumped to use golang 1.21. We should at least use that version for any custom builds from now on. Next version of OCP we'll need to support is 4.16. Their CI operator relies on golang 1.21 builder image at [1]. Let's use this same image. [1] https://github.com/openshift/release/blob/077ae802a5461f63a34ba5157cc2bc2783db7219/ci-operator/config/openshift/oc/openshift-oc-release-4.16.yaml#L25 Signed-off-by: Camilla Conte <[email protected]>
New changes are detected. LGTM label has been removed. |
Thanks @gkurz, just updated with your commit message. |
@spotlesstofu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- Description of the problem which is fixed/What is the use case
- What I did
- How to verify it
- Description for the changelog