Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang version to 1.21 #380

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

spotlesstofu
Copy link
Contributor

- Description of the problem which is fixed/What is the use case

- What I did

- How to verify it

- Description for the changelog

@openshift-ci openshift-ci bot requested review from gkurz and pmores March 21, 2024 15:07
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2024
Copy link

openshift-ci bot commented Mar 21, 2024

Hi @spotlesstofu. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bpradipt
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2024
@bpradipt bpradipt requested a review from snir911 April 2, 2024 10:44
Copy link
Member

@gkurz gkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @spotlesstofu !

@gkurz
Copy link
Member

gkurz commented May 30, 2024

/retest-required

@bpradipt
Copy link
Contributor

@spotlesstofu shouldn't this be targeted for devel branch ?

@gkurz
Copy link
Member

gkurz commented May 30, 2024

@spotlesstofu shouldn't this be targeted for devel branch ?

Indeed I overlooked it was targetting a dummy branch... @spotlesstofu is the PR ok to go to devel ?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 31, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2024
@spotlesstofu spotlesstofu changed the base branch from devel-test to devel May 31, 2024 13:02
@spotlesstofu
Copy link
Contributor Author

@gkurz it is OK now. The bot tells it needs rebase, but it shouldn't. I changed the target branch and rebased already.

@gkurz
Copy link
Member

gkurz commented May 31, 2024

/test

Copy link

openshift-ci bot commented May 31, 2024

@gkurz: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test ci-index-openshift-sandboxed-containers-operator-bundle
  • /test images

The following commands are available to trigger optional jobs:

  • /test check
  • /test sandboxed-containers-operator-e2e

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gkurz
Copy link
Member

gkurz commented May 31, 2024

/test all

Dockerfile Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2024
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@gkurz
Copy link
Member

gkurz commented Jun 5, 2024

Thanks @spotlesstofu !

We don't formally ask for it but it is generally good practice to add some extra info in the commit message and a S-o-b tag.

e.g.

Bump golang version to 1.21

Downstream OSC was already bumped to use golang 1.21. We should at least use
that version for any custom builds from now on.

Next version of OCP we'll need to support is 4.16. Their CI operator relies on golang
1.21 builder image at [1]. Let's use this same image.

[1] https://github.com/openshift/release/blob/077ae802a5461f63a34ba5157cc2bc2783db7219/ci-operator/config/openshift/oc/openshift-oc-release-4.16.yaml#L25

Signed-off-by: Camilla Conte <[email protected]>

Downstream OSC was already bumped to use golang 1.21. We should at least use
that version for any custom builds from now on.

Next version of OCP we'll need to support is 4.16. Their CI operator relies on golang
1.21 builder image at [1]. Let's use this same image.

[1] https://github.com/openshift/release/blob/077ae802a5461f63a34ba5157cc2bc2783db7219/ci-operator/config/openshift/oc/openshift-oc-release-4.16.yaml#L25

Signed-off-by: Camilla Conte <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
Copy link

openshift-ci bot commented Jun 5, 2024

New changes are detected. LGTM label has been removed.

@spotlesstofu
Copy link
Contributor Author

Thanks @gkurz, just updated with your commit message.

@gkurz gkurz merged commit a3ffed7 into openshift:devel Jun 5, 2024
2 of 4 checks passed
Copy link

openshift-ci bot commented Jun 5, 2024

@spotlesstofu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check 5accd07 link false /test check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants