Fix make test to unbreak make clean
#429
Conversation
`make test` is known to be failing since a long time. An issue is that it thus leaks a directory that prevents `make clean` to succeed because of restrictive file access modes. Separate the building of the test, which introduces the file access mode issue, from the actual test run. This allows to fully benefit from the access mode fixing introduced by PR openshift#240. Signed-off-by: Greg Kurz <[email protected]>
Why would it need it ? Do you have a case where this PR isn't enough for |
|
@gkurz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I thought the bin/k8s directory was created read only. |
It isn't. Thanks ! |
- Description of the problem which is fixed/What is the use case
make testis known to be failing since a long time. An issue is that it thus leaks a directory that preventsmake cleanto succeed because of restrictive file access modes.- What I did
Separate the building of the test, which introduces the file access mode issue, from the actual test run. This allows to fully benefit from the access mode fixing introduced by PR #240.
- How to verify it
make test# which will likely failmake clean# always succeed with this PR, fail otherwise