Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.12] OCPBUGS-18529: Reduce operator and config-daemon verbosity #819

Merged
merged 5 commits into from
Nov 8, 2023
Merged

[release-4.12] OCPBUGS-18529: Reduce operator and config-daemon verbosity #819

merged 5 commits into from
Nov 8, 2023

Commits on Sep 5, 2023

  1. Set zap log TimeEncoder 

    Set a TimeEncoder for zap logging system
to have more speaking timestamp.

from `1.6893201844680622e+09` to
`2023-07-14T09:52:29.539392293Z`

Signed-off-by: Andrea Panattoni <[email protected]>
    @zeeke
    zeeke authored and openshift-cherrypick-robot committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    b35cbe0 View commit details
    Browse the repository at this point in the history

  2. Reduce SriovOperator verbosity 

    In `renderDevicePluginConfigData()`, avoid
logging the full ResourceList for every resource in the loop.

Avoid logging in helper functions, as they can be invoked in loops.

Signed-off-by: Andrea Panattoni <[email protected]>
    @zeeke
    zeeke authored and openshift-cherrypick-robot committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    792575e View commit details
    Browse the repository at this point in the history

  3. Avoid logging devlink warning 

    Devlink mode is not supported by every SR-IOV NIC model.

Signed-off-by: Andrea Panattoni <[email protected]>
    @zeeke
    zeeke authored and openshift-cherrypick-robot committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    25b1d3a View commit details
    Browse the repository at this point in the history

  4. Reduce vebosity of config-damon 

    Log `getLinkType(): ...` only if LogLevel == 2

Signed-off-by: Andrea Panattoni <[email protected]>
    @zeeke
    zeeke authored and openshift-cherrypick-robot committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    e398bdb View commit details
    Browse the repository at this point in the history

  5. Avoid reconciling policies multiple times 

    `SriovNetworkNodePolicy` reconcile function lists all node policies
and updates all SriovNetworkNodeState. Hence there is no need to
resync all of them periodically.

Avoid triggering multiple reconciliations when creating multiple
policies in a row (that is what happens when using yaml files).

Signed-off-by: Andrea Panattoni <[email protected]>
    @zeeke
    zeeke authored and openshift-cherrypick-robot committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3692e2b View commit details
    Browse the repository at this point in the history