Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge change to master #20

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Merge change to master #20

merged 2 commits into from
Apr 17, 2019

Commits on Apr 17, 2019

  1. Add -v and -failfast when running e2e test 

    Signed-off-by: Chmouel Boudjnah <[email protected]>
    @chmouel
    chmouel committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    5fa66cb View commit details
    Browse the repository at this point in the history

  2. Remove admin privileges 

    * Remove admin priviliged rights: `anyuid` and `cluster-admin`.

* Add uidwrapper to set a fixed username

  By default openshift runs as random user which get git < 2.0 confused and fail
  its operations. Use a wrapper around some containers (git-init/creds-init) to
  set a fixed uid.

https://docs.okd.io/latest/creating_images/guidelines.html#openshift-specific-guidelines

* Use some trickery for envsubst

    Envsubst is a stuborn whiny child who wants to subst our variables even tho
    we don't want to modify those.

    Since there is no way to exclude some variables, we have our beautiful
    DOLLAR string replacing the dollar and we sed 's//' it after that envsubst
    have done its dirty work.

Signed-off-by: Chmouel Boudjnah <[email protected]>
    @chmouel
    chmouel committed Apr 17, 2019
    Configuration menu
    Copy the full SHA
    1d9ef22 View commit details
    Browse the repository at this point in the history