Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-26553: Cherry pick fix assignment 4.14 #230

Merged
merged 3 commits into from
Jan 18, 2024
Merged

OCPBUGS-26553: Cherry pick fix assignment 4.14 #230

merged 3 commits into from
Jan 18, 2024

Conversation

liornoy
Copy link

@liornoy liornoy commented Jan 18, 2024

Backports 3 commits to fix the assignment error from #228 and #196

xagent003 and others added 3 commits January 18, 2024 01:20
@xagent003 @liornoy
Rechecking pending Pods (conflict resolved)
8d0ffaf
@andreaskaris @liornoy
Improve AssignmentError message
4c82b45 
Signed-off-by: Andreas Karis <[email protected]>
@andreaskaris @liornoy
IterateForAssignment: Properly handle invalid syntax for exclude range
a723f69 
Correctly handle errors from parsing exclude ranges to avoid issues with
nil pointer exceptions.
Parse single IP addresses such as 192.168.123.10 or fe02::10 and
convert them to CIDRs by appending the correct prefix.

Signed-off-by: Andreas Karis <[email protected]>
@liornoy liornoy requested a review from dougbtv as a code owner January 18, 2024 00:44
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 18, 2024
@openshift-ci-robot
Copy link
Contributor

@liornoy: This pull request references Jira Issue OCPBUGS-26553, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-18893 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-18893 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backports 3 commits to fix the assignment error from #228 and #196

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from fepan and maiqueb January 18, 2024 00:44
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

@liornoy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zshi-redhat
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liornoy, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@zshi-redhat
Copy link
Contributor

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 18, 2024
@weliang1
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5b11534 into openshift:release-4.14 Jan 18, 2024
3 checks passed
@openshift-ci-robot
Copy link
Contributor

@liornoy: Jira Issue OCPBUGS-26553: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26553 has been moved to the MODIFIED state.

In response to this:

Backports 3 commits to fix the assignment error from #228 and #196

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liornoy
Copy link
Author

liornoy commented Jan 18, 2024

/cherry-pick 4.13

@liornoy liornoy deleted the cherry-pick-fix-assignment-4.14 branch January 18, 2024 17:05
@liornoy liornoy mentioned this pull request Jan 18, 2024
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-multus-whereabouts-ipam-cni-container-v4.14.0-202401190511.p0.g5b11534.assembly.stream for distgit ose-multus-whereabouts-ipam-cni.
All builds following this will include this PR.

@liornoy
Copy link
Author

liornoy commented Jan 24, 2024

/jira-refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv Awaiting requested review from dougbtv dougbtv is a code owner

@fepan fepan Awaiting requested review from fepan

@maiqueb maiqueb Awaiting requested review from maiqueb

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@zshi-redhat zshi-redhat

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.