Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds search parameters with and / or logic #57

Merged
merged 9 commits into from
Apr 20, 2021
Merged

Adds search parameters with and / or logic #57

merged 9 commits into from
Apr 20, 2021

Conversation

rkodev
Copy link
Contributor

@rkodev rkodev commented Mar 25, 2021

Adds search parameters with and / or logic

@rkodev rkodev mentioned this pull request Mar 25, 2021
3 tasks
@rkodev
Copy link
Contributor Author

rkodev commented Mar 25, 2021

This PR has a practical example of a patient search with the equals logic being applied. The example does not have the ability to perform partial searches as the SDK does not yet support the search

Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, can you please add test

vincent-karuri
vincent-karuri previously approved these changes Mar 25, 2021
@rkodev rkodev added Blocked Item is blocked by another prerequisite WIP labels Apr 9, 2021
@rkodev
Copy link
Contributor Author

rkodev commented Apr 9, 2021

The andorid-fhir SDK has significantly diverged changing the current implementation of the search API. We can merge the PR after refactoring to accommodate search API

pld
pld previously approved these changes Apr 9, 2021
@rkodev rkodev dismissed stale reviews from pld and vincent-karuri via 7148d18 April 19, 2021 15:01
@pld
Copy link
Member

pld commented Apr 19, 2021

sweet, can you add test for this?

@rkodev rkodev requested a review from Rkareko April 20, 2021 09:38
@rkodev rkodev removed WIP Blocked Item is blocked by another prerequisite labels Apr 20, 2021
@rkodev
Copy link
Contributor Author

rkodev commented Apr 20, 2021

Partially address #20

@rkodev rkodev merged commit eb690f8 into main Apr 20, 2021
@rkodev rkodev deleted the search-patients branch April 20, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants