Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support clean up the historical control_directory #126

Merged
merged 6 commits into from
Jul 31, 2023
Merged

support clean up the historical control_directory #126

merged 6 commits into from
Jul 31, 2023

Conversation

baoyachi
Copy link
Contributor

@baoyachi baoyachi commented Jul 28, 2023

fix #125

@jonhoo
Copy link
Collaborator

jonhoo commented Jul 28, 2023

This change is Reviewable

@baoyachi baoyachi changed the title support clean up the historical control_directory before creating a S… support clean up the historical control_directory Jul 28, 2023
src/builder.rs Outdated Show resolved Hide resolved
src/builder.rs Outdated Show resolved Hide resolved
baoyachi and others added 2 commits July 28, 2023 15:56
Co-authored-by: Jiahao XU <[email protected]>
Co-authored-by: Jiahao XU <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #126 (24b9d35) into master (fefd900) will decrease coverage by 1.05%.
The diff coverage is 24.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
Files Changed Coverage Δ
src/builder.rs 78.21% <24.00%> (-5.38%) ⬇️

src/builder.rs Show resolved Hide resolved
Co-authored-by: Jiahao XU <[email protected]>
src/builder.rs Outdated Show resolved Hide resolved
@NobodyXu
Copy link
Member

P.S. I would recommend rebasing against main instead of merging main into this PR, which will create an additional commit.

@NobodyXu NobodyXu merged commit 2e2bfb2 into openssh-rust:master Jul 31, 2023
12 checks passed
@jonhoo
Copy link
Collaborator

jonhoo commented Aug 20, 2023

I assume these mostly stuck around for when a connection failed, which has since been fixed (I think). I'm not in love with doing a recursive directory remove here invisibly on the user's behalf — feels like a recipe for accidentally deleting something unintentional down the line.

@NobodyXu
Copy link
Member

I assume these mostly stuck around for when a connection failed, which has since been fixed (I think). I'm not in love with doing a recursive directory remove here invisibly on the user's behalf — feels like a recipe for accidentally deleting something unintentional down the line.

This behavior is disabled by default, so I think it might be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to clean up the historical control_directory before creating a SessionBuilder?
4 participants