-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support clean up the historical control_directory #126
Conversation
Co-authored-by: Jiahao XU <[email protected]>
Co-authored-by: Jiahao XU <[email protected]>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files
|
Co-authored-by: Jiahao XU <[email protected]>
P.S. I would recommend rebasing against main instead of merging main into this PR, which will create an additional commit. |
I assume these mostly stuck around for when a connection failed, which has since been fixed (I think). I'm not in love with doing a recursive directory remove here invisibly on the user's behalf — feels like a recipe for accidentally deleting something unintentional down the line. |
This behavior is disabled by default, so I think it might be fine. |
fix #125