Use rfind to locate the @ in connection string #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
NobodyXu
approved these changes
Dec 19, 2023
|
Looks like we need to bump MSRV |
|
Given that all CI runs except for these two which runs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our counterparty uses email addresses as usernames. The connection string looks something like
The
resolvefunction looks for the@when parsing the URL usingfindfunction. That finds the first@which means the username isjohn.doeinstead of[email protected]. Usingrfindinstead resolves this issue. I'm not sure if this is valid according to the URL standard. It should not break any existing existing functionality as the hostname seems to not allow @ sign.Perhaps a better approach would be to rely on an external crate for this. The url crate comes to mind.