Added missing snippets tests #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwvolo
approved these changes
Aug 23, 2023
edwoodward
added a commit
that referenced
this pull request
Sep 22, 2023
* Added Ally Logo page (#1354) * Removed dbbackup because it does not solve to intended problem (#1355) * Removed ScoutAPM since it is no longer used (#1360) * only upload book data if the resource has a salesforce abbr (#1364) * Added cache clearing for general pages and fixed sticky note (#1365) * Changed query to sort by title instead of path (#1368) * Updated Partner query, removed reviews and updated tests (#1371) * Updated partner query, removed review sync and made all visible on website * Removed reviews and updated tests * Bump pillow from 9.1.1 to 9.3.0 in /requirements (#1366) Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.1.1 to 9.3.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@9.1.1...9.3.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Volo <[email protected]> * adding k12 pages, subjects * Add check on queryset for Resources (#1375) * Add check on queryset for Resources * Added test for bad slug * Removed Testimonial fields from School listing (#1377) * Clear resources on page save (#1381) * Added checks for book before creating resource download or sending to Salesforce (#1384) * Added checks for book before creating or sending to Salesforce * Edited if statement * Model and migration for new learning research page * Add new research page to home subpages * Add page to test * Python spacing * Update help text for some fields * fix class naming convention * added student and instructor resources to k12 subject pages * Tidy pages/model.py * Remove old research page in favor of new learning-research page * Remove unused field * remove seo title and search description from snippets/models * reverted update_partners.py * Added Ally Logo page (#1354) * Added cache clearing for general pages and fixed sticky note (#1365) * Ne wmigration for learningresearch page * Upgrade to Wagtail 3 (#1398) * Added Ally Logo page (#1354) * Changed wagtail.core to wagtail * Changed wagtail.tests to wagtail.test * Set StreamField to have use_json_field parameter * FieldPanel changes * Update to Wagtail 3.0.3 * merge migrations after rebase * Updated merged code for Wagtail 3 * Updated base.txt and locked-requirements.txt * Updated mapbox to 0.18.1 (#1403) * change schools/mapbox to sync monthly instead of daily (#1404) * Merge migration per wagtail * Remove all geneeral pages from sitemap except kinetic (#1402) * adjusting k12 data for frontend needs (#1405) * adjusting data for frontend needs - add label to subject dropdown - split name field in testimonials - fix images coming from snippets - modify subject category labels - add titles and icons to resources - move resources to book level * fix resource icons for k12 pages * add link_document_url to k12 subject pages * Added links to documentation in Confluence, Added Contributing file (#1414) * Fix import export (#1415) * Fixed translation and locale in export * More improvements * Lookup documents by title when importing * Uncommented save of a page * All documents now included * sort by book and git ignore icloud files (#1418) * subject sort in release added to development (#1420) * Errata form hotfix (#1423) * Removed /general/ from kinetic page sitemap entry (#1421) * Link preview fix (#1416) * Added page template to blog posts * Added page template to news app * Moved page template to blog folder * Folder to match FE URL with page template * Removed folders that did not work and put page template under news * middleware to create link preview * All bots working now * Added ua_parser to base.txt * Looked up correct object based on url path * Home page working and wrote tests * Removed NewsArticle use of template since it is not needed * Cleaned up template HTML * Improved HTML formatting * Remove all isbn 10 fields from books (#1428) * K12 tags fix into development (#1429) * Assignable page added to CMS (#1430) * First pass at assignables page * Assignable page added * Tweaked Assignable fields based on new text document (#1431) * Tweaked fields based on new text document * Latest round of changes * renamed book columns * Remove reference to assignable_book_link * Errata Export hotfix in development branch (#1440) * add resource_unlocked to k12 faculty resource lists (#1436) * Remove one page limitation on FAQ (#1441) * Replaced heading with heading_title_image (#1442) * Added add assignable cta fields (#1443) * Added add assignable cta fields * Added FAQ section * update readme versions and docker configs (#1447) * add cnx_id to book data (#1446) * Added field to resource API to match old Book API resource field (#1445) * Added resource_category field to resource snippets (#1448) * Added resource_category field to resource snippets * Added missing resource category on FacultyResource model for books * adding assignable resource (#1452) * adding assignable resource * Update 0053_alter_errata_resource.py * Update query for Opps to fetch UUID through the contact (#1453) * Added image carousel for Assignable (#1454) * Snippet for no webinar message (#1455) * update Book relationship query (#1459) * Fixed object structure from Salesforce (#1460) * remove student numbers from opp query (#1461) * Menus (#1462) * Code for adding menus for site to CMS * Menus working, but improvements needed * Made cleaner json * Added tests * Added new fields to Press page (#1463) * Resource external link no longer required (#1464) * Resource external link no longer required * Made link text not required * Improve handling pf privacy policy and encoded slugs (#1466) * Fixed resource link still being required (#1467) * Fixed resource link still being required * Fixed menu change * Removed validation errors on resources * Added About field * Removed locked-requirements.txt to prevent dependabot PRs * Add K12 and Research CTAs to home page (#1470) * readd SF name/abbr to book detail (#1472) * Tweaks to improve blog search results (#1471) * Tweaks to improve blog search results * Added subjects, categories and collections to search * Order by title (#1473) * Added write for us and editorial calendar to sitemap (#1474) * Added footer fields to news index page (#1475) * Modified errata query to prefetch book, removed review totals from Partners (#1476) * Modified errata query to prefetch book, removed review totals from Partners * Fixed query * undo last commit * Import working for non-book pages (#1478) * Handle exporting non-book pages * Changed content type check * improvements for non-book pages * Import working for non-book pages * added missing function and removed unused function * Removed print statements * Removed openstax logo fields from ally logos page (#1481) * Added book_uuid field and copied cnx_id value into it (#1482) * Only return live blog posts when querying by subject, collection or content type (#1483) * Updated packages (#1484) * Improved blog search results (#1486) * Fixed n+1 query issue on news search (#1487) * Webinars page (#1488) * Added collections and search to webinar page * Fixed search and search url * Removed print stmts and added test for search * Removed unneeded import * Removed websearch parameter * Added tests for 2 pages * changed name of webinar search API * K12 sitemap fix (#1490) * Sitemap fix for k12 and new subjects page * fixed k12 sitemap * New subjects page is in sitemap if flag is set to display * Now deals with -books on subject slugs correctly * Added missing Page tests (#1494) * added tests for 7 pages * added several more tests * Added Assignable snippet (#1495) * Started adding snippet * Added assignable available snippet * Added missing snippets tests (#1496) * Fix for docker on new macs (#1499) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Michael Volo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dmoreno <[email protected]> Co-authored-by: Chris Bendel <[email protected]> Co-authored-by: dmoreno27 <[email protected]> Co-authored-by: Devynn Moreno <[email protected]> Co-authored-by: Colby <[email protected]> Co-authored-by: Devynn Moreno <[email protected]> Co-authored-by: Thomas Woodward <[email protected]>
edwoodward
added a commit
that referenced
this pull request
Sep 22, 2023
* Added Ally Logo page (#1354) * Removed dbbackup because it does not solve to intended problem (#1355) * Removed ScoutAPM since it is no longer used (#1360) * only upload book data if the resource has a salesforce abbr (#1364) * Added cache clearing for general pages and fixed sticky note (#1365) * Changed query to sort by title instead of path (#1368) * Updated Partner query, removed reviews and updated tests (#1371) * Updated partner query, removed review sync and made all visible on website * Removed reviews and updated tests * Bump pillow from 9.1.1 to 9.3.0 in /requirements (#1366) Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.1.1 to 9.3.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@9.1.1...9.3.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Volo <[email protected]> * adding k12 pages, subjects * Add check on queryset for Resources (#1375) * Add check on queryset for Resources * Added test for bad slug * Removed Testimonial fields from School listing (#1377) * Clear resources on page save (#1381) * Added checks for book before creating resource download or sending to Salesforce (#1384) * Added checks for book before creating or sending to Salesforce * Edited if statement * Model and migration for new learning research page * Add new research page to home subpages * Add page to test * Python spacing * Update help text for some fields * fix class naming convention * added student and instructor resources to k12 subject pages * Tidy pages/model.py * Remove old research page in favor of new learning-research page * Remove unused field * remove seo title and search description from snippets/models * reverted update_partners.py * Added Ally Logo page (#1354) * Added cache clearing for general pages and fixed sticky note (#1365) * Ne wmigration for learningresearch page * Upgrade to Wagtail 3 (#1398) * Added Ally Logo page (#1354) * Changed wagtail.core to wagtail * Changed wagtail.tests to wagtail.test * Set StreamField to have use_json_field parameter * FieldPanel changes * Update to Wagtail 3.0.3 * merge migrations after rebase * Updated merged code for Wagtail 3 * Updated base.txt and locked-requirements.txt * Updated mapbox to 0.18.1 (#1403) * change schools/mapbox to sync monthly instead of daily (#1404) * Merge migration per wagtail * Remove all geneeral pages from sitemap except kinetic (#1402) * adjusting k12 data for frontend needs (#1405) * adjusting data for frontend needs - add label to subject dropdown - split name field in testimonials - fix images coming from snippets - modify subject category labels - add titles and icons to resources - move resources to book level * fix resource icons for k12 pages * add link_document_url to k12 subject pages * Added links to documentation in Confluence, Added Contributing file (#1414) * Fix import export (#1415) * Fixed translation and locale in export * More improvements * Lookup documents by title when importing * Uncommented save of a page * All documents now included * sort by book and git ignore icloud files (#1418) * subject sort in release added to development (#1420) * Errata form hotfix (#1423) * Removed /general/ from kinetic page sitemap entry (#1421) * Link preview fix (#1416) * Added page template to blog posts * Added page template to news app * Moved page template to blog folder * Folder to match FE URL with page template * Removed folders that did not work and put page template under news * middleware to create link preview * All bots working now * Added ua_parser to base.txt * Looked up correct object based on url path * Home page working and wrote tests * Removed NewsArticle use of template since it is not needed * Cleaned up template HTML * Improved HTML formatting * Remove all isbn 10 fields from books (#1428) * K12 tags fix into development (#1429) * Assignable page added to CMS (#1430) * First pass at assignables page * Assignable page added * Tweaked Assignable fields based on new text document (#1431) * Tweaked fields based on new text document * Latest round of changes * renamed book columns * Remove reference to assignable_book_link * Errata Export hotfix in development branch (#1440) * add resource_unlocked to k12 faculty resource lists (#1436) * Remove one page limitation on FAQ (#1441) * Replaced heading with heading_title_image (#1442) * Added add assignable cta fields (#1443) * Added add assignable cta fields * Added FAQ section * update readme versions and docker configs (#1447) * add cnx_id to book data (#1446) * Added field to resource API to match old Book API resource field (#1445) * Added resource_category field to resource snippets (#1448) * Added resource_category field to resource snippets * Added missing resource category on FacultyResource model for books * adding assignable resource (#1452) * adding assignable resource * Update 0053_alter_errata_resource.py * Update query for Opps to fetch UUID through the contact (#1453) * Added image carousel for Assignable (#1454) * Snippet for no webinar message (#1455) * update Book relationship query (#1459) * Fixed object structure from Salesforce (#1460) * remove student numbers from opp query (#1461) * Menus (#1462) * Code for adding menus for site to CMS * Menus working, but improvements needed * Made cleaner json * Added tests * Added new fields to Press page (#1463) * Resource external link no longer required (#1464) * Resource external link no longer required * Made link text not required * Improve handling pf privacy policy and encoded slugs (#1466) * Fixed resource link still being required (#1467) * Fixed resource link still being required * Fixed menu change * Removed validation errors on resources * Added About field * Removed locked-requirements.txt to prevent dependabot PRs * Add K12 and Research CTAs to home page (#1470) * readd SF name/abbr to book detail (#1472) * Tweaks to improve blog search results (#1471) * Tweaks to improve blog search results * Added subjects, categories and collections to search * Order by title (#1473) * Added write for us and editorial calendar to sitemap (#1474) * Added footer fields to news index page (#1475) * Modified errata query to prefetch book, removed review totals from Partners (#1476) * Modified errata query to prefetch book, removed review totals from Partners * Fixed query * undo last commit * Import working for non-book pages (#1478) * Handle exporting non-book pages * Changed content type check * improvements for non-book pages * Import working for non-book pages * added missing function and removed unused function * Removed print statements * Removed openstax logo fields from ally logos page (#1481) * Added book_uuid field and copied cnx_id value into it (#1482) * Only return live blog posts when querying by subject, collection or content type (#1483) * Updated packages (#1484) * Improved blog search results (#1486) * Fixed n+1 query issue on news search (#1487) * Webinars page (#1488) * Added collections and search to webinar page * Fixed search and search url * Removed print stmts and added test for search * Removed unneeded import * Removed websearch parameter * Added tests for 2 pages * changed name of webinar search API * K12 sitemap fix (#1490) * Sitemap fix for k12 and new subjects page * fixed k12 sitemap * New subjects page is in sitemap if flag is set to display * Now deals with -books on subject slugs correctly * Added missing Page tests (#1494) * added tests for 7 pages * added several more tests * Added Assignable snippet (#1495) * Started adding snippet * Added assignable available snippet * Added missing snippets tests (#1496) * Fix for docker on new macs (#1499) * Update models.py (#1502) * Update models.py * Create 0054_alter_errata_resource.py --------- Co-authored-by: Staxly <[email protected]> * Added other missing tests (#1500) * Webview settings test and start of press pages tests * Tests for allies * Additional tests for import-export * Added test for admin filter * Tests for mock functions * tests for Press pages * modify to test press page creation * Cleaned up news test code --------- Co-authored-by: Michael Harrison <[email protected]> * adding Assignable source to autofill (#1504) Co-authored-by: Staxly <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Michael Volo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dmoreno <[email protected]> Co-authored-by: Chris Bendel <[email protected]> Co-authored-by: dmoreno27 <[email protected]> Co-authored-by: Devynn Moreno <[email protected]> Co-authored-by: Colby <[email protected]> Co-authored-by: Devynn Moreno <[email protected]> Co-authored-by: Thomas Woodward <[email protected]> Co-authored-by: Staxly <[email protected]>
edwoodward
added a commit
that referenced
this pull request
Oct 6, 2023
* Added Ally Logo page (#1354) * Removed dbbackup because it does not solve to intended problem (#1355) * Removed ScoutAPM since it is no longer used (#1360) * only upload book data if the resource has a salesforce abbr (#1364) * Added cache clearing for general pages and fixed sticky note (#1365) * Changed query to sort by title instead of path (#1368) * Updated Partner query, removed reviews and updated tests (#1371) * Updated partner query, removed review sync and made all visible on website * Removed reviews and updated tests * Bump pillow from 9.1.1 to 9.3.0 in /requirements (#1366) Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.1.1 to 9.3.0. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@9.1.1...9.3.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Volo <[email protected]> * adding k12 pages, subjects * Add check on queryset for Resources (#1375) * Add check on queryset for Resources * Added test for bad slug * Removed Testimonial fields from School listing (#1377) * Clear resources on page save (#1381) * Added checks for book before creating resource download or sending to Salesforce (#1384) * Added checks for book before creating or sending to Salesforce * Edited if statement * Model and migration for new learning research page * Add new research page to home subpages * Add page to test * Python spacing * Update help text for some fields * fix class naming convention * added student and instructor resources to k12 subject pages * Tidy pages/model.py * Remove old research page in favor of new learning-research page * Remove unused field * remove seo title and search description from snippets/models * reverted update_partners.py * Added Ally Logo page (#1354) * Added cache clearing for general pages and fixed sticky note (#1365) * Ne wmigration for learningresearch page * Upgrade to Wagtail 3 (#1398) * Added Ally Logo page (#1354) * Changed wagtail.core to wagtail * Changed wagtail.tests to wagtail.test * Set StreamField to have use_json_field parameter * FieldPanel changes * Update to Wagtail 3.0.3 * merge migrations after rebase * Updated merged code for Wagtail 3 * Updated base.txt and locked-requirements.txt * Updated mapbox to 0.18.1 (#1403) * change schools/mapbox to sync monthly instead of daily (#1404) * Merge migration per wagtail * Remove all geneeral pages from sitemap except kinetic (#1402) * adjusting k12 data for frontend needs (#1405) * adjusting data for frontend needs - add label to subject dropdown - split name field in testimonials - fix images coming from snippets - modify subject category labels - add titles and icons to resources - move resources to book level * fix resource icons for k12 pages * add link_document_url to k12 subject pages * Added links to documentation in Confluence, Added Contributing file (#1414) * Fix import export (#1415) * Fixed translation and locale in export * More improvements * Lookup documents by title when importing * Uncommented save of a page * All documents now included * sort by book and git ignore icloud files (#1418) * subject sort in release added to development (#1420) * Errata form hotfix (#1423) * Removed /general/ from kinetic page sitemap entry (#1421) * Link preview fix (#1416) * Added page template to blog posts * Added page template to news app * Moved page template to blog folder * Folder to match FE URL with page template * Removed folders that did not work and put page template under news * middleware to create link preview * All bots working now * Added ua_parser to base.txt * Looked up correct object based on url path * Home page working and wrote tests * Removed NewsArticle use of template since it is not needed * Cleaned up template HTML * Improved HTML formatting * Remove all isbn 10 fields from books (#1428) * K12 tags fix into development (#1429) * Assignable page added to CMS (#1430) * First pass at assignables page * Assignable page added * Tweaked Assignable fields based on new text document (#1431) * Tweaked fields based on new text document * Latest round of changes * renamed book columns * Remove reference to assignable_book_link * Errata Export hotfix in development branch (#1440) * add resource_unlocked to k12 faculty resource lists (#1436) * Remove one page limitation on FAQ (#1441) * Replaced heading with heading_title_image (#1442) * Added add assignable cta fields (#1443) * Added add assignable cta fields * Added FAQ section * update readme versions and docker configs (#1447) * add cnx_id to book data (#1446) * Added field to resource API to match old Book API resource field (#1445) * Added resource_category field to resource snippets (#1448) * Added resource_category field to resource snippets * Added missing resource category on FacultyResource model for books * adding assignable resource (#1452) * adding assignable resource * Update 0053_alter_errata_resource.py * Update query for Opps to fetch UUID through the contact (#1453) * Added image carousel for Assignable (#1454) * Snippet for no webinar message (#1455) * update Book relationship query (#1459) * Fixed object structure from Salesforce (#1460) * remove student numbers from opp query (#1461) * Menus (#1462) * Code for adding menus for site to CMS * Menus working, but improvements needed * Made cleaner json * Added tests * Added new fields to Press page (#1463) * Resource external link no longer required (#1464) * Resource external link no longer required * Made link text not required * Improve handling pf privacy policy and encoded slugs (#1466) * Fixed resource link still being required (#1467) * Fixed resource link still being required * Fixed menu change * Removed validation errors on resources * Added About field * Removed locked-requirements.txt to prevent dependabot PRs * Add K12 and Research CTAs to home page (#1470) * readd SF name/abbr to book detail (#1472) * Tweaks to improve blog search results (#1471) * Tweaks to improve blog search results * Added subjects, categories and collections to search * Order by title (#1473) * Added write for us and editorial calendar to sitemap (#1474) * Added footer fields to news index page (#1475) * Modified errata query to prefetch book, removed review totals from Partners (#1476) * Modified errata query to prefetch book, removed review totals from Partners * Fixed query * undo last commit * Import working for non-book pages (#1478) * Handle exporting non-book pages * Changed content type check * improvements for non-book pages * Import working for non-book pages * added missing function and removed unused function * Removed print statements * Removed openstax logo fields from ally logos page (#1481) * Added book_uuid field and copied cnx_id value into it (#1482) * Only return live blog posts when querying by subject, collection or content type (#1483) * Updated packages (#1484) * Improved blog search results (#1486) * Fixed n+1 query issue on news search (#1487) * Webinars page (#1488) * Added collections and search to webinar page * Fixed search and search url * Removed print stmts and added test for search * Removed unneeded import * Removed websearch parameter * Added tests for 2 pages * changed name of webinar search API * K12 sitemap fix (#1490) * Sitemap fix for k12 and new subjects page * fixed k12 sitemap * New subjects page is in sitemap if flag is set to display * Now deals with -books on subject slugs correctly * Added missing Page tests (#1494) * added tests for 7 pages * added several more tests * Added Assignable snippet (#1495) * Started adding snippet * Added assignable available snippet * Added missing snippets tests (#1496) * Fix for docker on new macs (#1499) * Update models.py (#1502) * Update models.py * Create 0054_alter_errata_resource.py --------- Co-authored-by: Staxly <[email protected]> * Added other missing tests (#1500) * Webview settings test and start of press pages tests * Tests for allies * Additional tests for import-export * Added test for admin filter * Tests for mock functions * tests for Press pages * modify to test press page creation * Cleaned up news test code --------- Co-authored-by: Michael Harrison <[email protected]> * adding Assignable source to autofill (#1504) Co-authored-by: Staxly <[email protected]> * Comment out events code and remove events models from db (#1505) * Update models.py (#1509) * Update models.py removing three fields from errata view via model * Create 0055_remove_errata_accounts_user_email_and_more.py adding migration * Update admin.py removing fields from search (this never worked anway) --------- Co-authored-by: Staxly <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Michael Volo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dmoreno <[email protected]> Co-authored-by: Chris Bendel <[email protected]> Co-authored-by: dmoreno27 <[email protected]> Co-authored-by: Devynn Moreno <[email protected]> Co-authored-by: Colby <[email protected]> Co-authored-by: Devynn Moreno <[email protected]> Co-authored-by: Thomas Woodward <[email protected]> Co-authored-by: Staxly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.