New openstreetmap-carto release, v4.1.0

[kocio-pl]

A new version of openstreetmap-carto, v4.1.0, has been released.

[tomhughes]

This appears to be completely broken:

Jul 30 23:17:03 scorch.openstreetmap.org renderd[12937]:    reason: Postgis Plugin: ERROR:  column "bridge" does not exist
                                                         LINE 1: SELECT ST_AsBinary("way") AS geom,"bridge","int_tunnel","int...
                                                                                                   ^
                                                         in executeQuery Full sql was: 'SELECT ST_AsBinary("way") AS geom,"bridge","int_tunnel","intermittent","waterway" FROM (SELECT
                                                             way, COALESCE(historic, barrier) AS feature
                                                           FROM (SELECT way,
                                                             ('barrier_' || (CASE WHEN barrier IN ('chain', 'city_wall', 'embankment', 'ditch', 'fence', 'guard_rail',
                                                                   'handrail', 'hedge', 'kerb', 'retaining_wall', 'wall') THEN barrier ELSE NULL END)) AS barrier,
                                                             ('historic_' || (CASE WHEN historic = 'citywalls' THEN historic ELSE NULL END)) AS historic
                                                             FROM planet_osm_line
                                                             WHERE barrier IN ('chain', 'city_wall', 'embankment', 'ditch', 'fence', 'guard_rail',
                                                                   'handrail', 'hedge', 'kerb', 'retaining_wall', 'wall')
                                                               OR historic = 'citywalls'
                                                               AND (waterway IS NULL OR waterway NOT IN ('river', 'canal', 'derelict_canal', 'stream', 'drain', 'ditch', 'wadi'))
                                                           ) AS features
                                                         ) AS line_barriers WHERE "way" && ST_SetSRID('BOX3D(1249745.412463303 5429933.615325265,1252497.145481572 5432685.348343533)'::box3d, 900913)'

[tomhughes]

I'm rolling back to 4.0.0 for now.

[kocio-pl]

Hm, where does this code come from? The only similar place where I could find COALESCE(historic, barrier) is in the line-barriers layer:

https://github.com/gravitystorm/openstreetmap-carto/blob/master/project.mml#L594

but I don't see any bridge here. This layer was also not changed since many months.

[matthijsmelissen]

The SQL SELECT ST_AsBinary("way") AS geom,"bridge","int_tunnel","intermittent","waterway" implies that in #line-barriers (or .barriers) we are having selector with bridge, int_tunnel, intermittent and waterway (something like [bridge = 'yes']). This gives an error as bridge is not defined in our SQL.

However, I don't see such a selector. On my machine it works fine.

[matthijsmelissen]

@tomhughes What is the carto version you use, again?

[pnorman]

wfm with carto 0.18.0

[pnorman]

I also checked the XML with carto 0.18.2 and Mapnik API 3.0.0, and the XML looks fine.

[kocio-pl]

What about other tile rendering servers? Could you test it with machine other than scorch?

[tomhughes]

We're using 0.16.3 by the looks of it.

I didn't check all the machines but judging by the way the combined graphs crashed to zero I assume they were all affected.

[tomhughes]

So 0.16.3 and 0.18.2 definitely produce different XML and the 0.16.3 version looks very broken, with every layer having name="undefined" just as one example.

[tomhughes]

So I see @pnorman changed the minimum from 0.16.0 to 0.18.0 in gravitystorm/openstreetmap-carto@c169d8b which was actually just before the 4.0.0 release though apparently it didn't actually matter at that point.

I'll update the servers and try again tonight but please do try to warn me when you make changes like that so that I can make sure the servers are updated.

[matthijsmelissen]

This is caused by gravitystorm/openstreetmap-carto#2626 (comment). We should have specified the bump in version number here.

Would upgrading the carto version be possible @tomhughes? I think reverting the change that caused this would also bevsn option.

[tomhughes]

I've literally just done an update of carto and as I say I'll try the rollout again this evening.

[matthijsmelissen]

Sorry, my message crossed yours!