Make player movement more smooth #322
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The physics calculation in the server and in clients should be similar so that movement prediction could work. This change may improve movement prediction.
The movement prediction code for the main player is very ugly and will break when the player walks through the door with a button. I don't know how this should be done properly in Godot.
|
HOW TO REVIEW:
|
nicemicro
reviewed
Nov 20, 2021
| @@ -159,8 +161,9 @@ func run_physics(motion): | |||
| velocity.x = lerp(prev_velocity.x, 0, 0.17) | |||
| if velocity.y == 0: | |||
| velocity.y = lerp(prev_velocity.y, 0, 0.17) | |||
| # TODO: provide a delta value to this function and use it here | |||
| velocity = move_and_slide(velocity) | |||
| var collision = move_and_collide(velocity / 60) | |||
There was a problem hiding this comment.
what is the reason for this being divided by 60?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current problems: