Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loose mode, fixes #24 #26

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Add loose mode, fixes #24 #26

merged 2 commits into from
Mar 20, 2018

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented Mar 19, 2018 •
edited by matteofigus
Loading

Closes #24

Loose mode allows for pick language that doesn't exactly match accept-language, e.g. it allows to select en when only en-US is present. It also allows to select more specific language if it is present first in the list.

matteofigus
matteofigus suggested changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@matteofigus matteofigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks!
Can I ask you to update the readme to document the new option as part of this Pull Request?

@sheerun
Copy link
Contributor Author

sheerun commented Mar 20, 2018

@matteofigus Done

matteofigus
matteofigus approved these changes Mar 20, 2018
View reviewed changes
Copy link
Contributor

@matteofigus matteofigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@matteofigus matteofigus merged commit 409b4ca into opentable:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteofigus matteofigus matteofigus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheerun @matteofigus