Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit archive size to 1GB for 32bit arch #8

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

meringu
Copy link
Contributor

@meringu meringu commented Sep 23, 2024

tofudl is currently failing to build on 32bit, as this constant is too large:

./downloader_download_version.go:105:19: branding.MaximumUncompressedFileSize (untyped int constant 10737418240) overflows int
./downloader_download_version.go:108:71: cannot use branding.MaximumUncompressedFileSize (untyped int constant 10737418240) as int value in argument to fmt.Errorf (overflows)

This was set to 1TB, which is probably too high anyway, as downloading a 1TB item would probably be considered a denial of service (at least on my systems that run OpenTofu). 1GB should be plenty, as the tofu archives are only in the 10's of megabytes range.

I'm after 32bit, as we compile Atlantis for 32bit, and am trying to add support for OpenTofu here: runatlantis/atlantis#4499

@abstractionfactory abstractionfactory merged commit 8c1e00f into opentofu:main Sep 23, 2024
6 checks passed
@abstractionfactory
Copy link
Contributor

Hi @meringu, thank you for this!

@meringu meringu deleted the 32-bit branch September 23, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants