Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump jaeger-client to 1.3.2 #101

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Bump jaeger-client to 1.3.2 #101

merged 1 commit into from
Aug 12, 2020

Conversation

danielwegener
Copy link
Contributor

Not sure how the process is intended to work but it would be nice to have new features like
#60
in the starter.

@danielwegener
Copy link
Contributor Author

Just saw that this closes #97

@pavolloffay pavolloffay merged commit d35811a into opentracing-contrib:master Aug 12, 2020
@pavolloffay pavolloffay mentioned this pull request Aug 12, 2020
Closed
geoand added a commit that referenced this pull request Sep 21, 2020
@geoand
Revert "Upgrade to jaeger-client 1.3.2 (#101)"
e586c50 
This reverts commit d35811a
geoand added a commit that referenced this pull request Sep 21, 2020
@geoand
Bump Spring Boot to 2.3.4.Release for Jaeger 1.1 (#107)
2bbbe0e 
* Revert "Upgrade to jaeger-client 1.3.2 (#101)"

This reverts commit d35811a

* Revert "Made W3C trace context propagation configurable (#103)"

This reverts commit 0b95db4

* Fix license headers

* Bump to Spring Boot 2.3.4
@mfvanek
Copy link

mfvanek commented Oct 28, 2020

Hi guys,
Hi @pavolloffay,
Could you please clarify the reason why this PR was reverted?
We've faced with issue on logging spans and we need the MDCScopeManager in the Jaeger spring starter out of the box.
Do you have any plans to bump Jaeger version up to 1.3.2?

@geoand
Copy link
Collaborator

geoand commented Oct 28, 2020

I reverted because I wanted to get out a version with SB 2.3 and the previous version of Jaeger.
I'll do a new release with the latest version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielwegener @mfvanek @geoand @pavolloffay