Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

Commit

Permalink
Implement a simpler Span propagation without lifetime handling. (#188)
Browse files Browse the repository at this point in the history
- Scope replaces ActiveSpan, without sharing a common ancestor with Span.
- ScopeManager replaces ActiveSpanSource.
- No reference-count to handle Span's lifetime.
- A simple thread-local based ScopeManager.
  • Loading branch information
carlosalberto authored Sep 25, 2017
1 parent f52e7c2 commit 4ae4656
Show file tree
Hide file tree
Showing 39 changed files with 785 additions and 901 deletions.
109 changes: 0 additions & 109 deletions opentracing-api/src/main/java/io/opentracing/ActiveSpan.java

This file was deleted.

50 changes: 0 additions & 50 deletions opentracing-api/src/main/java/io/opentracing/ActiveSpanSource.java

This file was deleted.

143 changes: 0 additions & 143 deletions opentracing-api/src/main/java/io/opentracing/BaseSpan.java

This file was deleted.

43 changes: 43 additions & 0 deletions opentracing-api/src/main/java/io/opentracing/Scope.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/*
* Copyright 2016-2017 The OpenTracing Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/
package io.opentracing;

import java.io.Closeable;

/**
* A {@link Scope} formalizes the activation and deactivation of a {@link Span}, usually from a CPU standpoint.
*
* <p>
* Many times a {@link Span} will be extant (in that {@link Span#finish()} has not been called) despite being in a
* non-runnable state from a CPU/scheduler standpoint. For instance, a {@link Span} representing the client side of an
* RPC will be unfinished but blocked on IO while the RPC is still outstanding. A {@link Scope} defines when a given
* {@link Span} <em>is</em> scheduled and on the path.
*/
public interface Scope extends Closeable {
/**
* Mark the end of the active period for the current thread and {@link Scope},
* updating the {@link ScopeManager#active()} in the process.
*
* <p>
* NOTE: Calling {@link #close} more than once on a single {@link Scope} instance leads to undefined
* behavior.
*/
@Override
void close();

/**
* @return the {@link Span} that's been scoped by this {@link Scope}
*/
Span span();
}
Loading

0 comments on commit 4ae4656

Please sign in to comment.