-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In process propagation #2
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<?php | ||
|
||
namespace OpenTracing; | ||
|
||
/** | ||
* Keeps track of the current active `Span`. | ||
*/ | ||
interface ActiveSpanSource | ||
{ | ||
/** | ||
* Activates an `Span`, so that it is used as a parent when creating new spans. | ||
* The implementation must keep track of the active spans sequence, so | ||
* that previous spans can be resumed after a deactivation. | ||
* | ||
* @param Span $span | ||
*/ | ||
public function activate(Span $span); | ||
|
||
/** | ||
* Returns current active `Span`. | ||
* | ||
* @return Span | ||
*/ | ||
public function getActiveSpan(); | ||
|
||
/** | ||
* Deactivate the given `Span`, restoring the previous active one. | ||
* | ||
* This method must take in consideration that a `Span` may be deactivated | ||
* when it's not really active. In that case, the current active stack | ||
* must not be changed (idempotency). | ||
* | ||
* Do not confuse it with the finish concept: | ||
* - $span->deactivate() -> the span is not active but still "running" | ||
* - $span->finish() -> the span is finished and deactivated | ||
* | ||
* @param Span $span | ||
*/ | ||
public function deactivate(Span $span); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
<?php | ||
|
||
namespace OpenTracing; | ||
|
||
final class NoopActiveSpanSource implements ActiveSpanSource | ||
{ | ||
public static function create() | ||
{ | ||
return new self(); | ||
} | ||
|
||
public function activate(Span $span) | ||
{ | ||
} | ||
|
||
public function getActiveSpan() | ||
{ | ||
return NoopSpan::create(); | ||
} | ||
|
||
public function deactivate(Span $span) | ||
{ | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You use
startManualSpan
for the parent here. I think this is a copy-and-paste mistake, since you want to demonstrate the use ofstartActiveSpaǹ
.