This repository has been archived by the owner on May 23, 2023. It is now read-only.
Move set/get_baggage back to Span; add SpanContext.baggage #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :rtype : str | ||
| :return: value of the Baggage item with given key, or None. | ||
| :rtype: dict | ||
| :return: returns baggage associated with this SpanContext or {}. |
There was a problem hiding this comment.
nit: the or {} is superfluous (if there's no baggage, then of course the map would be empty, right?)
There was a problem hiding this comment.
I wanted to emphasize that a valid dictionary must always be returned, because the use of @property lands itself to usage like ctx.baggage["somekey"].
There was a problem hiding this comment.
I see. Well, "nit" either way, no strong feelings here.
There was a problem hiding this comment.
Oh: can you add a note that the caller should not modify the return value?
There was a problem hiding this comment.
doh, indeed it does. great minds, etc...
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per opentracing/opentracing.io#106
cc @bensigelman