-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(location-field): make location group order configurable #771
base: master
Are you sure you want to change the base?
feat(location-field): make location group order configurable #771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, but could you add in one of the stories a control to toggle on/off the new renderOtherFirst
prop? Also, please update the snapshots.
const OtherFeaturesHeader = () => ( | ||
<S.MenuGroupHeader as={headingType} bgColor="#333" key="other-header"> | ||
<FormattedMessage | ||
description="Text for header above the 'other'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description looks unfinished, could you fix please?
…/otp-ui into reorder-other-to-first
Blocked by #774 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please use Storybook controls to illustrate renderOtherFirst
?
const [otherControl, setOtherControl] = useState(false); | ||
return ( | ||
<> | ||
<label htmlFor="other-input"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make Storybook create the controls using argTypes
instead? (Storybook will add that to its "Controls" tab - I should have mentioned that in my previous review but somehow thought you knew) Do that for this story only. Refer to e.g.
FlexRoute.argTypes = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think an explicit boolean to push a specific category to the top is a good idea
/** | ||
* If true, make "Other" category (addresses, POIs, etc.) first in the results container. | ||
*/ | ||
renderOtherFirst?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this an array instead? Where we can manually set an order of categories to prioritize (and those will be displayed first). This might require a bigger refactor but I think it's worth it. Let me know if you'd like to discuss in more detail offline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so like ["STOPS", "STATIONS", "OTHER"]
as the config item?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one
Allows configuration of the order of the returned location group results, so that if you pass
renderOtherFirst
through the config, it puts the "other" category first in the results, above stops and stations.