Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCT/IB: Skip multi-thread memory registration for symmetric key #9447

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

tvegas1
Copy link
Contributor

@tvegas1 tvegas1 commented Oct 26, 2023

What

Skip multi-threaded memory registration when symmetric key is requested and FW supports it.

Why ?

Simplest approach, could later be improved to generate KSM(MT) with specific mkey_index using KSM wrapper introduced by related #9424.

How ?

Add corresponding tests and assertion.

brminich
brminich previously approved these changes Oct 26, 2023
Copy link
Contributor

@brminich brminich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 besides minor comment

src/uct/ib/mlx5/dv/ib_mlx5dv_md.c Outdated Show resolved Hide resolved
@yosefe
Copy link
Contributor

yosefe commented Oct 27, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s), but failed to run 1 pipeline(s).

@yosefe yosefe enabled auto-merge October 27, 2023 06:56
@yosefe yosefe merged commit db02fae into openucx:master Oct 27, 2023
113 of 115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants