UCT/IB/MLX5: Refactor KSM functions and extend logging #9472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems it affects the code which is significantly modified in #9424 |
yosefe
force-pushed
the
topic/uct-ib-mlx5-print-ksm-details-to
branch
from
11acda2
to
d20602c
Compare
|
@ivankochin @brminich can you pls take a look? |
brminich
reviewed
Jan 14, 2024
src/uct/ib/mlx5/dv/ib_mlx5dv_md.c
Outdated
Comment on lines
208
to
213
| if (reason != NULL) { | ||
| ucs_trace("%s: initialize ksm_data_addr list for %s address 0x%lx " | ||
| "length %zu iova 0x%" PRIx64, | ||
| uct_ib_device_name(&md->super.dev), reason, address, length, | ||
| iova); | ||
| } |
There was a problem hiding this comment.
minor: can be inline func and reused also in uct_ib_mlx5_devx_reg_ksm_data_mt (together with check reason != NULL)
ivankochin
reviewed
Jan 15, 2024
ivankochin
reviewed
Jan 16, 2024
|
BTW it seems like the title of this PR doesn't fully represent the content anymore. |
yosefe
changed the title
yosefe
changed the title
ivankochin
approved these changes
Jan 17, 2024
yosefe
force-pushed
the
topic/uct-ib-mlx5-print-ksm-details-to
branch
from
ed3e63e
to
eaf7877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Improve KSM debug logging