Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that open state can be set to get default-opened behavior #236

Conversation

dandclark
Copy link
Collaborator

@dandclark dandclark commented Dec 4, 2020

Per the resolution from the 3 December 2020 meeting, clarify that the open state will be author-visible and author-changeable by both a JS property and an HTML content attribute. This resolves #229 since that allows authors to make a <select> open by default.

Additionally:

  • Fix the formatting/wording of the "Default State" section, which formerly had the misleading top-level bullet "The state of the <select> is set to open".
  • Update the heading of the table in the "<select> Properties" section to agree with the section name.

Longer term we should consider formalizing which of the properties are reflected as HTML content attributes. Right now there isn't really anything specifying that normatively.

@gregwhitworth gregwhitworth merged commit 0db07d7 into openui:master Dec 9, 2020
@gregwhitworth
Copy link
Member

We should loop in relevant other platform folks given the discussion at TPAC regarding the open attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SELECT] Open select by default
2 participants