-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy popup explainer from mfreed7 repo #490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment as I'd like the proposal link on the left side to link to the actual current proposal which is your new.popup.explainer.md
rather than updating the current proposal to link to the new one.
Additionally, the routing seems to not be working for your file in the preview
Looking at the preview it I don't see a link to the new popup proposal in the sidebar: The link to the new page returns a 404 too, |
Right - I'm completely unfamiliar with the setup of the OpenUI site. I'll try to figure it out. Any clues would be appreciated! |
Alright, I think I figured things out and relinked/renamed things appropriately. Please take a look and let me know if you see any broken links in the preview. They looked good to me. I ended up keeping the original link (https://open-ui.org/components/popup.research.explainer) for the new explainer, and renaming the original things to |
Thanks for making the changes. One minor change if we're going to link to both let's adjust the terminology of the naming:
|
Retested and works as expected! 😄 |
Thanks for the review. No problem on renaming - done. PTAL and let me know if this looks like what you were expecting.
Great, thanks for looking! Anything else you all see that I need to change, or is this ok to land? (I'd like to send an updated Intent to Prototype, and I need to link to this explainer.) |
Looks right to me. |
This is a (mostly) copy/paste from my personal repo into the OpenUI repo. I updated the other popup-related explainers to have a pointer to this new approach.
I've left these as .MD files, since there's nothing but pure Markdown. Let me know if I need to rename them to mdx.
Once this lands, I'll add an "obsolete" message at the top of my personal repo documents, pointing to this copy.