Update Popup explainer to incorporate all recent changes #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrico1234
reviewed
May 10, 2022
|
I did a one-pass of the preview site, and the document looks great and well-formatted! Happy to approve, but not sure if you want someone more familiar with the spec to review the content :) |
andrico1234
approved these changes
May 10, 2022
scottaohara
reviewed
May 10, 2022
|
Thanks for the reviews. @scottaohara let me know if you want me to wait for you to take a look at the rest before I land it. |
|
going to finish up now. |
scottaohara
reviewed
May 10, 2022
Thanks for the great review! I resolved everything except one question. It might warrant a new issue to discuss further. |
|
I'm going to land this now, but let me know what you think about the mouse-down vs. mouse-up question and I can open an issue for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also revamps the explainer significantly, changing the language from "proposal" to "explainer". Many details are also added, such as what "light dismiss" really means, the "nearest open ancestral popup" algorithm, and many more details. I also added links back to many of the recent resolutions where some of these decisions made.
I'm sure there are typos and issues here, but I did a first editing pass. Comments appreciated.