Update pop-up explainer to reflect recent resolutions #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrico1234
approved these changes
Jun 27, 2022
|
Looks good to me @mfreed7 , are you happy for me to merge, or would you like another eye on it? |
|
Thanks! Happy to merge if you’re comfortable with it. |
...and it looks like the TAG is going to review Pop Up this week, so it'd be good if the updates were landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily this involves renaming "popup" to either "popUp" (for code) or "pop-up" (for prose). This PR also includes renaming
popup=asynctopopup=manual, and some additions of issue links.