[select] Use the new ::behavior selector and clarify that ::part doesn't work #714
Conversation
|
@gregwhitworth @josepharhar , are either of you able to review the content for this change? :) |
| `::part()` can be used to style the `button`, `selected-value`, and `listbox` parts of the control. | ||
| `::behavior()` can be used to style the `button`, `selected-value`, and `listbox` parts of the control. | ||
|
|
||
| Note that the `::part()` pseudo-element selector only matches elements in the user-agent shadow tree, and hence, fails to match any author-provided part (as in [slotting your own content](#slotting-your-own-content)). |
There was a problem hiding this comment.
can you please wrap this with a div with a class of .note
There was a problem hiding this comment.
Also see my above comment on whether ::behavior is defined somewhere as this should be covered in that definition; not in selectmenu itself.
| @@ -52,18 +52,18 @@ Selectmenu provides a variety of tools to help with styling, including pseudo-se | |||
|
|
|||
| ### Styling parts of the control | |||
|
|
|||
| One way to style the control to match your requirements is to use the CSS `::part()` pseudo-element to select the different parts within the control's anatomy that you wish to style. | |||
| One way to style the control to match your requirements is to use the CSS `::behavior()` pseudo-element, newly introduced for the selectmenu element, to select the different parts within the control's anatomy that you wish to style. | |||
There was a problem hiding this comment.
We should link out to the definition of behavior. Do we have one in CSSWG yet? If not we should probably expound on this.
There was a problem hiding this comment.
I don't know of a CSSWG issue proposing ::behavior yet.
If we remove the "newly introduced for the selectmenu element" part is that good enough to merge this now?
I'm hesitant to open a CSSWG issue proposing this just yet since domenic's general feedback could change how this works. I haven't even opened an HTML issue for selectmenu yet.
There was a problem hiding this comment.
This is not in CSSWG yet.
I'm hesitant to open a CSSWG issue proposing this just yet since domenic's general feedback could change how this works. I haven't even opened an HTML issue for selectmenu yet.
I feel the same. Should we create a draft spec of ::behavior somewhere at open-ui?
|
@josepharhar @xiaochengh I'm presuming we should abandon this PR? |
|
Yeah, it doesn't seem relevant with the element model. |
Fixes #645