-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split & tidy up the Invokers proposals, scoping for v1 invokers #965
split & tidy up the Invokers proposals, scoping for v1 invokers #965
Conversation
I'm happy to review this (unfortunately not in the next few days, I'm otherwise swamped), but I wanted to ask: does this indicate anything about the urgency or priority of landing |
There's no change in the prose that either prioritises or defers I'm hoping that we can ship |
I very much hope we can get interest as a fast follow up. I do think it has more as yet unanswered questions but I'm hopeful we can make progress on it. I believe in Chrome there's already a vast amount of code that can be reused, from the popover hint and hover experimentation. |
Great, thank you both! I'm happy to assist with code reviews or whatever you need.
I would agree - Chromium has a full prototype of the hover-trigger and hover-detrigger code, plus CSS properties for controlling the delays, plus testing. That'll all likely need modification, and it doesn't handle non-mouse triggering, but it should hopefully be a good start. |
2d04678
to
bcb7eff
Compare
@mfreed7 could I get your eyes on this again? I think it'd be useful to separate these explainers so we can iterate more on the |
I've left some comments but overall this looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Lots of comments, but this LGTM to land. We can iterate after landing.
Thanks for the review from both! Aside from the various typos/nits, the changes of substance are:
|
That's ok by me, but let's definitely not forget about that part. I do think it's important. |
This split the Invokers proposal into 2 separate sections; "Invokers" (what might also be known as
invoketarget
/invokeaction
and related behaviour) and "Interest Invokers" (what might also be known asinteresttarget
). It also starts to demarcate chunks of the "Invokers" proposal into what we're initially shipping, vs what will come as a follow-up.(I'm aware this is a big diff but... it's quite a bit to tease these apart, I can try and split it into smaller PRs if people would feel better about that?)
Closes #964, #956