Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split & tidy up the Invokers proposals, scoping for v1 invokers #965

Conversation

keithamus
Copy link
Collaborator

@keithamus keithamus commented Dec 1, 2023

This split the Invokers proposal into 2 separate sections; "Invokers" (what might also be known as invoketarget/invokeaction and related behaviour) and "Interest Invokers" (what might also be known as interesttarget). It also starts to demarcate chunks of the "Invokers" proposal into what we're initially shipping, vs what will come as a follow-up.

(I'm aware this is a big diff but... it's quite a bit to tease these apart, I can try and split it into smaller PRs if people would feel better about that?)

Closes #964, #956

@mfreed7
Copy link
Collaborator

mfreed7 commented Dec 2, 2023

I'm happy to review this (unfortunately not in the next few days, I'm otherwise swamped), but I wanted to ask: does this indicate anything about the urgency or priority of landing interesttarget? Personally, that's almost a bit more interesting (ha!) to me than invoketarget, because it unlocks tooltips and unblocks popover=hint. Are you still invested in the interest target proposal?

@keithamus
Copy link
Collaborator Author

There's no change in the prose that either prioritises or defers interesttarget. I'm still very much interested in pursuing it, it (hopefully) answers some as-yet-unanswered a11y patterns (see w3c/aria-practices#128, I'm participating in the aria-wg in the hopes that we can thread this needle).

I'm hoping that we can ship invoketarget to use as learnings for interesttarget, scoping invokers down to dialog/popover pushes that forward so my hopes for interesttarget making progress are higher than they were last week 😉

@lukewarlow
Copy link
Collaborator

I very much hope we can get interest as a fast follow up. I do think it has more as yet unanswered questions but I'm hopeful we can make progress on it.

I believe in Chrome there's already a vast amount of code that can be reused, from the popover hint and hover experimentation.

@mfreed7
Copy link
Collaborator

mfreed7 commented Dec 4, 2023

Great, thank you both! I'm happy to assist with code reviews or whatever you need.

I believe in Chrome there's already a vast amount of code that can be reused, from the popover hint and hover experimentation.

I would agree - Chromium has a full prototype of the hover-trigger and hover-detrigger code, plus CSS properties for controlling the delays, plus testing. That'll all likely need modification, and it doesn't handle non-mouse triggering, but it should hopefully be a good start.

@keithamus keithamus force-pushed the split-tidy-up-the-invokers-proposals-scoping-for-v1-invokers branch from 2d04678 to bcb7eff Compare January 21, 2024 20:11
@keithamus
Copy link
Collaborator Author

@mfreed7 could I get your eyes on this again? I think it'd be useful to separate these explainers so we can iterate more on the interest parts.

@lukewarlow
Copy link
Collaborator

I've left some comments but overall this looks good.

Copy link
Collaborator

@mfreed7 mfreed7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Lots of comments, but this LGTM to land. We can iterate after landing.

@keithamus
Copy link
Collaborator Author

Thanks for the review from both! Aside from the various typos/nits, the changes of substance are:

  • Pulling out the descriptions on alternative HIDs and explicitly calling out that this is an in-progress area that's out of scope for the initial release.
  • Removing mention of adding delays, punting to another discussion/issue/PR.

@mfreed7
Copy link
Collaborator

mfreed7 commented Feb 9, 2024

  • Removing mention of adding delays, punting to another discussion/issue/PR.

That's ok by me, but let's definitely not forget about that part. I do think it's important.

@lukewarlow lukewarlow merged commit 91b3b77 into openui:main Feb 12, 2024
5 checks passed
@keithamus keithamus deleted the split-tidy-up-the-invokers-proposals-scoping-for-v1-invokers branch February 19, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[invokers] Update invokers proposal to clearly define a v1.
3 participants