Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main to feature/benchmarking #1236

Merged
merged 3 commits into from
Aug 6, 2023
Merged

Merge main to feature/benchmarking #1236

merged 3 commits into from
Aug 6, 2023

Conversation

samet-akcay
Copy link
Contributor

Description

  • Provide a summary of the modification as well as the issue that has been resolved. List any dependencies that this modification necessitates.

  • Fixes # (issue)

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

samet-akcay and others added 3 commits August 3, 2023 20:36
@samet-akcay
Configure readthedocs via .readthedocs.yaml file (#1229)
0c7444e
@ashwinvaidya17
🚚 Refactor Benchmarking Script (#1216)
784767f 
* New printing stuff

* Remove dead code + address codacy issues

* Refactor try/except + log to comet/wandb during runs

* pre-commit error

* third-party configuration

---------

Co-authored-by: Ashwin Vaidya <[email protected]>
@samet-akcay
Update CODEOWNERS
5a46d03
@samet-akcay samet-akcay enabled auto-merge (squash) August 6, 2023 10:53
@github-actions github-actions bot added Dependencies Pull requests that update a dependency file CI Setup Benchmarking Tools labels Aug 6, 2023
@samet-akcay samet-akcay merged commit b730050 into feature/benchmarking Aug 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 Awaiting requested review from ashwinvaidya17

@yunchu yunchu Awaiting requested review from yunchu

@djdameln djdameln Awaiting requested review from djdameln

Assignees
No one assigned
Labels
Benchmarking CI Dependencies Pull requests that update a dependency file Setup Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samet-akcay @ashwinvaidya17