-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update benchmarking notebook #1242
Merged
samet-akcay
merged 29 commits into
openvinotoolkit:main
from
samet-akcay:docs/notebook-update
Aug 8, 2023
Merged
Update benchmarking notebook #1242
samet-akcay
merged 29 commits into
openvinotoolkit:main
from
samet-akcay:docs/notebook-update
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ashwinvaidya17
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
NagatoYuki0943
added a commit
to NagatoYuki0943/anomalib
that referenced
this pull request
Aug 9, 2023
Update benchmarking notebook (openvinotoolkit#1242)
samet-akcay
added a commit
that referenced
this pull request
Aug 9, 2023
* Configure readthedocs via `.readthedocs.yaml` file (#1229) * 🚚 Refactor Benchmarking Script (#1216) * New printing stuff * Remove dead code + address codacy issues * Refactor try/except + log to comet/wandb during runs * pre-commit error * third-party configuration --------- Co-authored-by: Ashwin Vaidya <[email protected]> * Update CODEOWNERS * Enable training with only normal images for MVTec (#1241) * ignore mask check when dataset has only normal samples * update changelog * Revert "🚚 Refactor Benchmarking Script" (#1239) Revert "🚚 Refactor Benchmarking Script (#1216)" This reverts commit 784767f. * Update benchmarking notebook (#1242) * Fix metadata path * Update benchmarking notebook --------- Co-authored-by: Ashwin Vaidya <[email protected]> Co-authored-by: Ashwin Vaidya <[email protected]> Co-authored-by: Dick Ameln <[email protected]>
samet-akcay
added a commit
that referenced
this pull request
Aug 10, 2023
* Configure readthedocs via `.readthedocs.yaml` file (#1229) * 🚚 Refactor Benchmarking Script (#1216) * New printing stuff * Remove dead code + address codacy issues * Refactor try/except + log to comet/wandb during runs * pre-commit error * third-party configuration --------- Co-authored-by: Ashwin Vaidya <[email protected]> * Update CODEOWNERS * Enable training with only normal images for MVTec (#1241) * ignore mask check when dataset has only normal samples * update changelog * Revert "🚚 Refactor Benchmarking Script" (#1239) Revert "🚚 Refactor Benchmarking Script (#1216)" This reverts commit 784767f. * Update benchmarking notebook (#1242) * Fix metadata path * Update benchmarking notebook * Fix links to model architecture images (#1245) * Fix links to architecture images * Change links to raw files * Wandb unwatch method belongs to experiment, not logger (#1246) unwatch method belongs to experiment, not logger --------- Co-authored-by: Ashwin Vaidya <[email protected]> Co-authored-by: Ashwin Vaidya <[email protected]> Co-authored-by: Dick Ameln <[email protected]> Co-authored-by: Blaž Rolih <[email protected]> Co-authored-by: Sean Aubin <[email protected]>
samet-akcay
added a commit
that referenced
this pull request
Aug 15, 2023
* Configure readthedocs via `.readthedocs.yaml` file (#1229) * 🚚 Refactor Benchmarking Script (#1216) * New printing stuff * Remove dead code + address codacy issues * Refactor try/except + log to comet/wandb during runs * pre-commit error * third-party configuration --------- Co-authored-by: Ashwin Vaidya <[email protected]> * Update CODEOWNERS * Enable training with only normal images for MVTec (#1241) * ignore mask check when dataset has only normal samples * update changelog * Revert "🚚 Refactor Benchmarking Script" (#1239) Revert "🚚 Refactor Benchmarking Script (#1216)" This reverts commit 784767f. * Update benchmarking notebook (#1242) * Fix metadata path * Update benchmarking notebook * Fix links to model architecture images (#1245) * Fix links to architecture images * Change links to raw files * Wandb unwatch method belongs to experiment, not logger (#1246) unwatch method belongs to experiment, not logger * (Minor change) Added the tracer_kwargs to the TorchFXFeatureExtractor class (#1214) * Added tracer_kwargs to torchfx * Added tracer_kwargs on docstring * Replace cdist in Patchcore (#1267) * Ignore hidden directories when creating `Folder` dataset (#1268) * Remove `config` from argparse in OpenVINO inference script. (#1257) * Fix metadata path * Remove leftover argument * Update openvino entrypoint script * Fix EfficientAD number of steps for optimizer lr change? (#1266) * Fix metadata path * Fix number of steps --------- Co-authored-by: Ashwin Vaidya <[email protected]> Co-authored-by: Ashwin Vaidya <[email protected]> Co-authored-by: Dick Ameln <[email protected]> Co-authored-by: Blaž Rolih <[email protected]> Co-authored-by: Sean Aubin <[email protected]> Co-authored-by: JoaoGuibs <[email protected]>
samet-akcay
added a commit
that referenced
this pull request
Aug 23, 2023
* add per-image overlap (pimo) * modif plot pimo curves * add warning about memory * tiny bug * add tuto ipynb * make image classes a return * fix ipynb * add tests for binclf curve * add test to binclf * add aupimo tests * ruff * Configure readthedocs via `.readthedocs.yaml` file (#1229) * Update binclf_curve.py * 🚚 Refactor Benchmarking Script (#1216) * New printing stuff * Remove dead code + address codacy issues * Refactor try/except + log to comet/wandb during runs * pre-commit error * third-party configuration --------- Co-authored-by: Ashwin Vaidya <[email protected]> * Update CODEOWNERS * Enable training with only normal images for MVTec (#1241) * ignore mask check when dataset has only normal samples * update changelog * Revert "🚚 Refactor Benchmarking Script" (#1239) Revert "🚚 Refactor Benchmarking Script (#1216)" This reverts commit 784767f. * Update benchmarking notebook (#1242) * Fix metadata path * Update benchmarking notebook * add per-image overlap (pimo) * modif plot pimo curves * add warning about memory * tiny bug * add tuto ipynb * make image classes a return * fix ipynb * add tests for binclf curve * add test to binclf * add aupimo tests * ruff * Update binclf_curve.py * refactor from future pr * correct tests * add test * fix test * add plots tests * correct codacy stuff * correct codacy stuff --------- Co-authored-by: Samet Akcay <[email protected]> Co-authored-by: Ashwin Vaidya <[email protected]> Co-authored-by: Ashwin Vaidya <[email protected]> Co-authored-by: Dick Ameln <[email protected]>
Merged
samet-akcay
added a commit
that referenced
this pull request
Sep 12, 2023
* add per-image overlap (pimo) * modif plot pimo curves * add warning about memory * tiny bug * add tuto ipynb * make image classes a return * fix ipynb * add tests for binclf curve * add test to binclf * add aupimo tests * ruff * Configure readthedocs via `.readthedocs.yaml` file (#1229) * Update binclf_curve.py * 🚚 Refactor Benchmarking Script (#1216) * New printing stuff * Remove dead code + address codacy issues * Refactor try/except + log to comet/wandb during runs * pre-commit error * third-party configuration --------- Co-authored-by: Ashwin Vaidya <[email protected]> * Update CODEOWNERS * Enable training with only normal images for MVTec (#1241) * ignore mask check when dataset has only normal samples * update changelog * Revert "🚚 Refactor Benchmarking Script" (#1239) Revert "🚚 Refactor Benchmarking Script (#1216)" This reverts commit 784767f. * Update benchmarking notebook (#1242) * Fix metadata path * Update benchmarking notebook * add per-image overlap (pimo) * modif plot pimo curves * add warning about memory * tiny bug * add tuto ipynb * make image classes a return * fix ipynb * add tests for binclf curve * add test to binclf * add aupimo tests * ruff * Update binclf_curve.py * refactor from future pr * add auc boxplot * Apply suggestions from code review * update demo nb * correct tests * add test * fix test * add plots tests * add tests to pimo * fix plt warning * fix docstring warning * add tests to common * add tests for plot module and small fixes * --amend * clear ouputs in notebook * correct typo * correct codacy stuff * correct codacy stuff * merge * fix kernel spec in 502_perimg_metrics.ipynb * fix types in boxplot * Update src/anomalib/utils/metrics/perimg/pimo.py Co-authored-by: Samet Akcay <[email protected]> --------- Co-authored-by: Samet Akcay <[email protected]> Co-authored-by: Ashwin Vaidya <[email protected]> Co-authored-by: Ashwin Vaidya <[email protected]> Co-authored-by: Dick Ameln <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the benchmarking notebook.
Fixes [Bug]: Benchmark tool raises exception #1109
Changes
Checklist